From d8c454747bd9902383a4e5a0f434eece65a7240f Mon Sep 17 00:00:00 2001
From: Paul Howarth <p...@city-fan.org>
Date: Thu, 28 Jan 2016 15:07:42 +0000
Subject: Spec clean-up

- Classify buildreqs by usage
- Don't ship the tests
- Drop provides/requires filters as they're no longer needed
- Drop %defattr, redundant since rpm 4.4
- Don't need to remove empty directories from the buildroot
---
 perl-Class-C3-XS.spec | 59 ++++++++++++++++++++++++++++++++++++++-------------
 1 file changed, 44 insertions(+), 15 deletions(-)

diff --git a/perl-Class-C3-XS.spec b/perl-Class-C3-XS.spec
index f34d250..334cc78 100644
--- a/perl-Class-C3-XS.spec
+++ b/perl-Class-C3-XS.spec
@@ -1,21 +1,50 @@
 Name:          perl-Class-C3-XS
 Version:       0.13
-Release:       18%{?dist}
+Release:       19%{?dist}
 Summary:       XS speedups for Class::C3
 License:       GPL+ or Artistic
 Group:         Development/Libraries
 URL:           http://search.cpan.org/dist/Class-C3-XS/
 Source0:       
http://search.cpan.org/CPAN/authors/id/F/FL/FLORA/Class-C3-XS-%{version}.tar.gz
 BuildRoot:     %{_tmppath}/%{name}-%{version}-%{release}-root-%(id -nu)
+# Module Build
+BuildRequires: coreutils
+BuildRequires: findutils
+BuildRequires: gcc
+BuildRequires: make
+BuildRequires: perl
+%if 0%{?fedora} > 6 || 0%{?rhel} > 5
+BuildRequires: perl-devel
+%endif
+# Dependencies of bundled Module::Install
+BuildRequires: perl(Config)
+BuildRequires: perl(Cwd)
 BuildRequires: perl(ExtUtils::MakeMaker)
-BuildRequires: perl(Sub::Name)
+BuildRequires: perl(ExtUtils::Manifest)
+BuildRequires: perl(ExtUtils::MM_Unix)
+BuildRequires: perl(File::Find)
+BuildRequires: perl(File::Path)
+BuildRequires: perl(File::Spec)
+BuildRequires: perl(FileHandle)
+BuildRequires: perl(FindBin)
+BuildRequires: perl(JSON)
+BuildRequires: perl(Parse::CPAN::Meta)
+BuildRequires: perl(vars)
+BuildRequires: perl(YAML::Tiny)
+# Module Runtime
+BuildRequires: perl(strict)
+BuildRequires: perl(warnings)
+BuildRequires: perl(XSLoader)
+# Test Suite
+BuildRequires: perl(base)
 BuildRequires: perl(Test::More) >= 0.47
+# Optional Tests
+BuildRequires: perl(Sub::Name)
 BuildRequires: perl(Test::Pod)
+# Dependencies
 Requires:      perl(:MODULE_COMPAT_%(eval "`perl -V:version`"; echo $version))
 
-# Filter bogus requires/provides
-%{?filter_from_requires: %filter_from_requires /^perl(base)$/d}
-%{?filter_from_provides: %filter_from_provides /^perl(t::.*)$/d}
+# Avoid provides from private shared objects
 %{?perl_default_filter}
 
 %description
@@ -26,12 +55,6 @@ it can find it. Do not use this package directly, use 
Class::C3 instead.
 %prep
 %setup -q -n Class-C3-XS-%{version}
 
-# Filter bogus provides and requires if we don't have %%{perl_default_filter}
-%global provfilt /bin/sh -c "%{__perl_provides} | grep -v '^perl(t::'"
-%define __perl_provides %{provfilt}
-%global reqfilt /bin/sh -c "%{__perl_requires} | grep -Fvx 'perl(base)'"
-%define __perl_requires %{reqfilt}
-
 %build
 perl Makefile.PL INSTALLDIRS=vendor
 make %{?_smp_mflags}
@@ -41,7 +64,6 @@ rm -rf %{buildroot}
 make pure_install DESTDIR=%{buildroot}
 find %{buildroot} -type f -name .packlist -exec rm -f {} \;
 find %{buildroot} -type f -name '*.bs' -a -size 0 -exec rm -f {} \;
-find %{buildroot} -depth -type d -exec rmdir {} \; 2>/dev/null
 %{_fixperms} %{buildroot}
 
 %check
@@ -51,13 +73,20 @@ make test
 rm -rf %{buildroot}
 
 %files
-%defattr(-,root,root,-)
-%doc ChangeLog README t/
+%doc ChangeLog README
 %{perl_vendorarch}/auto/Class/
 %{perl_vendorarch}/Class/
-%{_mandir}/man3/Class::C3::XS.3pm*
+%{_mandir}/man3/Class::C3::XS.3*
 
 %changelog
+* Thu Jan 28 2016 Paul Howarth <p...@city-fan.org> - 0.13-19
+- Spec clean-up
+  - Classify buildreqs by usage
+  - Don't ship the tests
+  - Drop provides/requires filters as they're no longer needed
+  - Drop %%defattr, redundant since rpm 4.4
+  - Don't need to remove empty directories from the buildroot
+
 * Thu Jun 18 2015 Fedora Release Engineering <rel-...@lists.fedoraproject.org> 
- 0.13-18
 - Rebuilt for https://fedoraproject.org/wiki/Fedora_23_Mass_Rebuild
 
-- 
cgit v0.11.2


        
http://pkgs.fedoraproject.org/cgit/perl-Class-C3-XS.git/commit/?h=perl-Class-C3-XS-0.13-19.fc24&id=d8c454747bd9902383a4e5a0f434eece65a7240f
--
Fedora Extras Perl SIG
http://www.fedoraproject.org/wiki/Extras/SIGs/Perl
perl-devel mailing list
perl-devel@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/perl-devel@lists.fedoraproject.org

Reply via email to