From 6eac9075cd601226ad39f673b624863fc5574a1f Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Petr=20P=C3=ADsa=C5=99?= <ppi...@redhat.com>
Date: Tue, 22 Mar 2016 09:31:34 +0100
Subject: Modernize spec file

---
 perl-Qt.spec | 49 +++++++++++++++++++++++++++++++------------------
 1 file changed, 31 insertions(+), 18 deletions(-)

diff --git a/perl-Qt.spec b/perl-Qt.spec
index 044999f..67ca44d 100644
--- a/perl-Qt.spec
+++ b/perl-Qt.spec
@@ -17,40 +17,51 @@ Patch3:         
Qt-0.96.0-Bundle-Devel-Peel-SvREFCNT_inc-removed-from-perl-5.2.p
 # Adjust to perl-5.20.0, bug #1136340, CPAN RT#98790, in new upstream
 # <git://anongit.kde.org/perlqt>
 Patch4:         
perlqt-4.14.2-Use-a-copy-of-the-Qt-AutoLoad-AUTOLOAD-variable.patch
-Requires:       perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo 
$version))
-
 BuildRequires:  coreutils
 BuildRequires:  cmake
-BuildRequires:  libdb-devel
-BuildRequires:  make
+# gcc for C standard library headers
 BuildRequires:  gcc
-BuildRequires:  gdbm-devel
+BuildRequires:  gcc-c++
+BuildRequires:  make
+BuildRequires:  perl
+BuildRequires:  perl-devel
+# Perl module used by qtcore/src/doxsubpp.pl and cmake/FindPerlMore.cmake
+BuildRequires:  perl(Config)
+BuildRequires:  perl(ExtUtils::MakeMaker)
+BuildRequires:  perl(File::Spec)
+BuildRequires:  perl(strict)
+BuildRequires:  perl(warnings)
 BuildRequires:  phonon-devel
 BuildRequires:  qimageblitz-devel
 BuildRequires:  qscintilla-devel
 BuildRequires:  qt-devel
 BuildRequires:  qwt-devel
 BuildRequires:  sed
+# smokegen-devel provided cmake modules for Qt components
+BuildRequires:  smokegen-devel
 BuildRequires:  smokeqt-devel
-
+# Run-time:
+# search in lib subdirectories, exclude examples,
+BuildRequires:  perl(base)
 BuildRequires:  perl(Carp)  
-BuildRequires:  perl(Devel::Peek)  
-BuildRequires:  perl(Exporter)  
-BuildRequires:  perl(ExtUtils::MakeMaker)
-BuildRequires:  perl(File::Spec)
-BuildRequires:  perl(List::MoreUtils)  
+BuildRequires:  perl(Exporter)
+BuildRequires:  perl(List::MoreUtils)
+BuildRequires:  perl(overload)
 BuildRequires:  perl(Scalar::Util)  
-BuildRequires:  perl(Test::More)
 BuildRequires:  perl(XSLoader)  
-BuildRequires:  perl(base)  
-BuildRequires:  perl(strict)  
+# Tests:
+# search for *.t files, they use modules from examples like Calculator
+BuildRequires:  perl(blib)
+BuildRequires:  perl(Devel::Peek)
+BuildRequires:  perl(lib)
+BuildRequires:  perl(Test::More)
 BuildRequires:  perl(utf8)
-BuildRequires:  perl(warnings)  
+Requires:       perl(:MODULE_COMPAT_%(eval "`perl -V:version`"; echo $version))
 
 %?perl_default_filter
+# Filter private modules
 %global __provides_exclude 
%{?__provides_exclude:%__provides_exclude|}::_(internal|overload)\\)
 %global __requires_exclude 
%{?__requires_exclude:%__requires_exclude|}::_(internal|overload)\\)
-%global __requires_exclude 
%{?__requires_exclude:%__requires_exclude|}^QtCore4\\.so
 
 %description
 This module provides Perl bindings for the Qt 4 libraries.
@@ -58,7 +69,7 @@ This module provides Perl bindings for the Qt 4 libraries.
 %package devel
 Summary:        Development files for perl-Qt
 License:        GPLv2+ and (GPL+ or Artistic) and (LGPLv2+ with exceptions or 
GPLv3+)
-Requires:       %{name} = %{version}-%{release}
+Requires:       %{name} = %{?epoch:%{epoch}:}%{version}-%{release}
 
 %description devel
 Development files for perl-Qt.
@@ -117,7 +128,8 @@ export PERL5LIB="$PWD/blib/lib:$PWD/blib/arch"
 make test
 
 %files
-%doc LICENSE README
+%license LICENSE
+%doc README
 %{perl_vendorarch}/*
 %exclude %dir %{perl_vendorarch}/auto/
 
@@ -130,6 +142,7 @@ make test
 %changelog
 * Wed Mar 23 2016 Petr Pisar <ppi...@redhat.com> - 0.96.0-17
 - Specify more dependencies
+- Modernize spec file
 
 * Thu Jun 18 2015 Fedora Release Engineering <rel-...@lists.fedoraproject.org> 
- 0.96.0-16
 - Rebuilt for https://fedoraproject.org/wiki/Fedora_23_Mass_Rebuild
-- 
cgit v0.12


        
http://pkgs.fedoraproject.org/cgit/perl-Qt.git/commit/?h=f23&id=6eac9075cd601226ad39f673b624863fc5574a1f
--
Fedora Extras Perl SIG
http://www.fedoraproject.org/wiki/Extras/SIGs/Perl
perl-devel mailing list
perl-devel@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/perl-devel@lists.fedoraproject.org

Reply via email to