Re: [IDEA] Drop into the debugger on failure

2004-07-08 Thread Michael G Schwern
On Thu, Jul 08, 2004 at 11:53:52PM +0100, Fergal Daly wrote: > The main point was that the OO way works right now, So does event hooks. Hooks are things you can hang stuff off of, but they're also used to snare things that might not want to be snared. In other words... use Test::Builder

Re: [IDEA] Drop into the debugger on failure

2004-07-08 Thread Fergal Daly
On Thu, Jul 08, 2004 at 04:37:06PM -0400, Michael G Schwern wrote: > With inheritence, only one variant can be used at a time. > > With event subscribers, lots of variants can be used at a time. > > Consider what happens when you want to use Test::AutoDebug and a hypothetical > module which color

Re: how to run test.pl before the t/*.t tests ?

2004-07-08 Thread Barbie
From: "Andy Lester" <[EMAIL PROTECTED]> > On Thu, Jul 08, 2004 at 04:20:38PM -0400, Michael G Schwern ([EMAIL PROTECTED]) wrote: > > > > [2] Want some fun? http://search.cpan.org/~dconway > > > > > > You have a sick sense of humour young man ;) > > > > He uses test.pl. Sic 'em. > > That sort of

Re: how to run test.pl before the t/*.t tests ?

2004-07-08 Thread Andy Lester
On Thu, Jul 08, 2004 at 04:20:38PM -0400, Michael G Schwern ([EMAIL PROTECTED]) wrote: > > > [2] Want some fun? http://search.cpan.org/~dconway > > > > You have a sick sense of humour young man ;) > > He uses test.pl. Sic 'em. That sort of cleanup is exactly what Phalanx is about. I think Par

Re: how to run test.pl before the t/*.t tests ?

2004-07-08 Thread Barbie
From: "Michael G Schwern" <[EMAIL PROTECTED]> > > It means test.pl's which use Test::More and fail will no longer cause > 'make test' to fail. But I doubt people are using test.pl and Test::More > much. I'm now trying to remember which distributions I tested recently with only test.pl, and can't.

Re: [IDEA] Drop into the debugger on failure

2004-07-08 Thread Michael G Schwern
On Thu, Jul 08, 2004 at 08:59:38PM +0100, Fergal Daly wrote: > On Thu, Jul 08, 2004 at 01:59:35PM -0400, Michael G Schwern wrote: > > Likely you'd control if you wanted this behavior with > > HARNESS_PERL_SWITCHES=-MTest::AutoDebug > > > > This can be implemented, currently, by adding a post hook

Re: how to run test.pl before the t/*.t tests ?

2004-07-08 Thread Michael G Schwern
On Thu, Jul 08, 2004 at 05:31:02PM +0100, Barbie wrote: > > [1] Test::More automatically exits abnormally on failure but > > I'm considering changing that to no longer be the default. > > Will this then mean all cpan-testing will PASS? It means test.pl's which use Test::More and fail will no long

Re: [IDEA] Drop into the debugger on failure

2004-07-08 Thread Fergal Daly
On Thu, Jul 08, 2004 at 01:59:35PM -0400, Michael G Schwern wrote: > Likely you'd control if you wanted this behavior with > HARNESS_PERL_SWITCHES=-MTest::AutoDebug > > This can be implemented, currently, by adding a post hook onto > Test::Builder->ok() with Hook::LexWrap or Sub::Uplevel. I'm c

Re: Test::More::is_deeply() bug

2004-07-08 Thread Fergal Daly
On Thu, Jul 08, 2004 at 03:22:57PM -0400, Michael G Schwern wrote: > What version of Test::More is that? Not the one it should have been! I had patched my version in work long ago and forgot about it. Oddly, someone else posted a patch against the original for the same thing on p5p the next day,

Re: Test::More::is_deeply() bug

2004-07-08 Thread Michael G Schwern
On Wed, Jun 30, 2004 at 03:29:22PM +0100, Fergal Daly wrote: > Actually, it seems that some of the patches were applied. The problem is > that is_deeply() delegates to ->is_eq() for non deep arguments but handles > it's own string comparison once you descend into the structure. The patch > below se

[IDEA] Drop into the debugger on failure

2004-07-08 Thread Michael G Schwern
What happens now: 1) Run tests 2) Test fails 3) Look at diagnostics 4a) If its enough information, fix the bug 4b) If not, run test in the debugger 5b) Continue to the point where the test failed 6b) Gather necessary info 7b) Fix the bug I want to eliminate 4b and 5b from this process. On

RE: how to run test.pl before the t/*.t tests ?

2004-07-08 Thread Barbie
On 08 July 2004 16:55 Michael G Schwern wrote: > Little known fact: The output of test.pl is completely ignored by > "make test". ... and really annoys cpan-testers who have to cut-n-paste all the reports that have NOT passed into FAIL reports. Though now I've fixed part of CPANPLUS it's not

Re: how to run test.pl before the t/*.t tests ?

2004-07-08 Thread Michael G Schwern
On Fri, Jun 18, 2004 at 04:52:42PM -0400, darren chamberlain wrote: > * Gabor Szabo [2004/06/18 23:34]: > > I am trying to add a bunch of tests in t/ using Test::More but in > > order to make sure we don't lose any previous test we would like to > > keep the test.pl file as it is. > > Is porting

Re: Test::Inline should not capture STDOUT, STDERR

2004-07-08 Thread Tim Bunce
On Wed, Jul 07, 2004 at 05:12:20PM -0700, chromatic wrote: > > Add no_plan while you're writing tests, run the tests, then when you're > done, change the plan to reflect the number of tests to run. I have a > brain-dead simple vim mapping to do just that. Aside: Would be good if someone maintain