Bug fix in Test::More 0.71 may reveal failures tests

2007-09-15 Thread Michael G Schwern
Test::More 0.71 fixed a subtle bug where a call to use_ok() inside a BEGIN block without a plan would be silently ignored. That is... use Test::More; BEGIN { use_ok('Exporter') } # for example plan tests => 1; pass(); would pass when it should have failed. Thi

Re: Bug fix in Test::More 0.71 may reveal failures tests

2007-09-15 Thread Jonathan Rockway
Michael G Schwern wrote: > Test::More 0.71 fixed a subtle bug where a call to use_ok() inside a BEGIN > block without a plan would be silently ignored. That is... > > use Test::More; > > BEGIN { use_ok('Exporter') } # for example > > plan tests => 1; > pass(); > > would pa

Re: Bug fix in Test::More 0.71 may reveal failures tests

2007-09-16 Thread Petr Pajas
oops. Applied to SVN, thanks. -- Petr On Sunday 16 September 2007, Jonathan Rockway wrote: > Michael G Schwern wrote: > > Test::More 0.71 fixed a subtle bug where a call to use_ok() inside a > > BEGIN block without a plan would be silently ignored. That is... > > > > use Test::More; > > > >

Re: Bug fix in Test::More 0.71 may reveal failures tests

2007-09-16 Thread Jonathan Rockway
Michael G Schwern wrote: > Test::More 0.71 fixed a subtle bug where a call to use_ok() inside a BEGIN > block without a plan would be silently ignored. That is... > > Found another, File::Finder. Patch to fix this is attached. Regards, Jonathan Rockway ff-useok-fix.t Description: Troff doc

Re: Bug fix in Test::More 0.71 may reveal failures tests

2007-09-17 Thread A. Pagaltzis
* Michael G Schwern <[EMAIL PROTECTED]> [2007-09-15 16:05]: > Test::More 0.71 fixed a subtle bug where a call to use_ok() > inside a BEGIN block without a plan would be silently ignored. > That is... > > use Test::More; > > BEGIN { use_ok('Exporter') } # for example > > plan t

Re: Bug fix in Test::More 0.71 may reveal failures tests

2007-09-17 Thread Jonathan Rockway
A. Pagaltzis wrote: > • AIX::Perfstat (disk.t) > • Business::BR::Ids (002_cpf_test.t 015_pis_test.t) > • Cache::FastMmap (6.t) > • CGI::Application::Plugin::LogDispatch (singleton.t) > • CGI::Application::Plugin::TT (04_singleton.t) > • CGI::Uploader (up_table_map.t) > • Data::FormValidator::FromDB

Re: Bug fix in Test::More 0.71 may reveal failures tests

2007-09-17 Thread A. Pagaltzis
* Jonathan Rockway <[EMAIL PROTECTED]> [2007-09-17 13:20]: > Your method was much better than my "try installing stuff I > need and see what fails" technique :) If anyone has a CPAN grepper script they could do an even better job with less effort than it took me. (It was incredibly tedious.) I am

Re: Bug fix in Test::More 0.71 may reveal failures tests

2007-09-17 Thread Thomas Klausner
Hi! On Mon, Sep 17, 2007 at 01:49:42PM +0200, A. Pagaltzis wrote: > * Jonathan Rockway <[EMAIL PROTECTED]> [2007-09-17 13:20]: > > Your method was much better than my "try installing stuff I > > need and see what fails" technique :) > > If anyone has a CPAN grepper script they could do an even be

Re: Bug fix in Test::More 0.71 may reveal failures tests

2007-09-17 Thread A. Pagaltzis
* Thomas Klausner <[EMAIL PROTECTED]> [2007-09-17 14:30]: > cpants takes ~ three hours to unpack each dist and run > cpants_lint on it. Hmm, that sounds eminently doable. If no one else pipes up, I’ll probably do a run tonight. Regards, -- Aristotle Pagaltzis //

Re: Bug fix in Test::More 0.71 may reveal failures tests

2007-09-17 Thread Adrian Howard
On 17 Sep 2007, at 12:49, A. Pagaltzis wrote: * Jonathan Rockway <[EMAIL PROTECTED]> [2007-09-17 13:20]: Your method was much better than my "try installing stuff I need and see what fails" technique :) If anyone has a CPAN grepper script they could do an even better job with less effort tha

Re: Bug fix in Test::More 0.71 may reveal failures tests

2007-09-17 Thread David E. Wheeler
On Sep 17, 2007, at 03:55, A. Pagaltzis wrote: • SVN::Notify (html.t) use_ok() is not in a BEGIN block in that file, so it should be fine, yes? Thanks for doing that search, though, very cool! Best, David

Re: Bug fix in Test::More 0.71 may reveal failures tests

2007-09-17 Thread A. Pagaltzis
* David E. Wheeler <[EMAIL PROTECTED]> [2007-09-17 19:25]: > On Sep 17, 2007, at 03:55, A. Pagaltzis wrote: > > >• SVN::Notify (html.t) > > use_ok() is not in a BEGIN block in that file, so it should be > fine, yes? Oh yeah, sorry. I confirmed the Google Codesearch hits by looking up the current

Re: Bug fix in Test::More 0.71 may reveal failures tests

2007-09-17 Thread A. Pagaltzis
Hi Adrian, * Adrian Howard <[EMAIL PROTECTED]> [2007-09-17 17:50]: > Just in case... you do know about CPAN::Mini::Extract yes? wow, no, I didn’t know about that. Very cool, I’m glad I couldn’t be bothered to do the job manually before I went to sleep. Now I don’t need to do much of any work at a

Re: Bug fix in Test::More 0.71 may reveal failures tests

2007-09-19 Thread Steve Peters
On Sat, Sep 15, 2007 at 05:06:01AM -0700, Michael G Schwern wrote: > Test::More 0.71 fixed a subtle bug where a call to use_ok() inside a BEGIN > block without a plan would be silently ignored. That is... > > use Test::More; > > BEGIN { use_ok('Exporter') } # for example > >