Re: Frequency of test.pl

2006-11-01 Thread Michael G Schwern
Steffen Mueller wrote: { name='no_test_pl', error=q{This distribution contains a file called 'test.pl' in its main distribution directory. This indicates that it uses the old style of creating test suites. Nowadays, tests belong into one or more *.t files in the t/

Re: Frequency of test.pl

2006-11-01 Thread Steffen Mueller
Hi again, Michael G Schwern schrieb: So making no_test_pl a kwalitee test is a good idea. of course, adding a mention in the docs helps, too. So I should have made it a patch. Sorry. I didn't have the svn sources. Hence: =item * has_test_pl And if people decide that this should be

Re: Frequency of test.pl

2006-11-01 Thread Steffen Mueller
Hi, Michael G Schwern schrieb: So making no_test_pl a kwalitee test is a good idea. So adding this to Module::CPANTS::Kwalitee::Files in the obvious place should do exactly that. Perhaps we should call it old_testing_scheme or so instead, but I'll go with your suggestion: {

Re: Frequency of test.pl

2006-11-01 Thread demerphq
On 11/1/06, Michael G Schwern [EMAIL PROTECTED] wrote: This distribution uses 'test.pl' for its tests. The output of 'test.pl' is not parsed. When make test is run by automated installers (for example, the CPAN shell) your tests will always appear to have passed no matter what the output of

Re: Frequency of test.pl

2006-11-01 Thread Steffen Mueller
Michael G Schwern schrieb: This doesn't really explain why test.pl is bad. [...] Agreed! This distribution uses 'test.pl' for its tests. The output of 'test.pl' is not parsed. When make test is run by automated installers (for example, the CPAN shell) your tests will always appear to

Re: Frequency of test.pl

2006-11-01 Thread Michael G Schwern
demerphq wrote: On 11/1/06, Michael G Schwern [EMAIL PROTECTED] wrote: This distribution uses 'test.pl' for its tests. The output of 'test.pl' is not parsed. When make test is run by automated installers (for example, the CPAN shell) your tests will always appear to have passed no matter