Re: Request for Comments: Package testing results analysis, result codes

2006-02-22 Thread Adam Kennedy
As for not testing suite at all, I'm not sure that's cause for an UNKNOWN, probably something else. If you see an UNKNOWN in CPAN test reports, it means that 'make test' returned "No tests defined". This is the result of no test suite at all. It should be caught, and may be cover by point 2.

Re: Request for Comments: Package testing results analysis, result codes

2006-02-22 Thread Barbie
> From: Adam Kennedy [mailto:[EMAIL PROTECTED] > > Barbie wrote: > > On Sun, Feb 19, 2006 at 10:22:20PM +1100, Adam Kennedy wrote: > >> 2. Incompatible packaging. > >> Packaging unwraps, but missing files for the testing scheme. > > > > You may want to split this into a result that contains n

Re: Request for Comments: Package testing results analysis, result codes

2006-02-20 Thread Matisse Enzer
On Feb 19, 2006, at 7:13 AM, Andreas J. Koenig wrote: Make sure you verify that all files in the distro are readable. Reject if the permissions are bogus. Recently we had an increasig number of distros that had absurd permissions. This reminds me - it doesn't seem like Module::Build allows on

Re: Request for Comments: Package testing results analysis, result codes

2006-02-20 Thread Tyler MacDonald
Adam Kennedy <[EMAIL PROTECTED]> wrote: > > I'd still like such a thing to be visible in some way. Of course > >you're going to happily skip tests that require a database if you don't > >have DBI_DSN set. > Not necesarily... it all depends on how important it is to you. I see > some potential

Re: Request for Comments: Package testing results analysis, result codes

2006-02-20 Thread Adam Kennedy
Now 100% skips, THAT could potentially be interesting, or maybe TODOs. But then I don't necesarily know why it would be worthy of a different result code. Is there metadata stored apart from these result codes? If so it might be useful to just store the statistics on skips. Assuming this

Re: Request for Comments: Package testing results analysis, result codes

2006-02-20 Thread Tyler MacDonald
Adam Kennedy <[EMAIL PROTECTED]> wrote: > Firstly is that it might turn an otherwise normal result into something > else, with no clear rule. It makes a judgement call that some level of > testing is good or bad, which isn't really the place of an installer to > call. > > The reason Kwalitee ha

Re: Request for Comments: Package testing results analysis, result codes

2006-02-20 Thread Sébastien Aperghis-Tramoni
Barbie wrote: > > 12. System is incompatible with the package. > > Linux::, Win32::, Mac:: modules. Irreconcilable differences. > > Not sure how you would cover this, but point 12 seems to possibly fit. > POSIX.pm is created for the platform it's installed on. A recent package > I was testing,

Re: Request for Comments: Package testing results analysis, result codes

2006-02-20 Thread Adam Kennedy
Regarding the blow, I may have been a little unclear on the layout of the points. The first line is the name of the error. Following lines are meant to provide details to help clarify what it means. Barbie wrote: On Sun, Feb 19, 2006 at 10:22:20PM +1100, Adam Kennedy wrote: 2. Incompatible p

Re: Request for Comments: Package testing results analysis, result codes

2006-02-20 Thread Yitzchak Scott-Thoennes
On Mon, Feb 20, 2006 at 11:36:27AM +, Barbie wrote: > > 12. System is incompatible with the package. > > Linux::, Win32::, Mac:: modules. Irreconcilable differences. > > Not sure how you would cover this, but point 12 seems to possibly fit. > POSIX.pm is created for the platform it's insta

Re: Request for Comments: Package testing results analysis, result codes

2006-02-20 Thread Tels
Moin, On Monday 20 February 2006 04:20, Adam Kennedy wrote: > (Andreas J. Koenig) wrote: > >> On Sun, 19 Feb 2006 22:22:20 +1100, Adam Kennedy <[EMAIL PROTECTED]> > >> said: > > > > > > 1. Broken or corrupt packaging. > > > A bad tarball, MANIFEST files missing. > > > > Make sur

Re: Request for Comments: Package testing results analysis, result codes

2006-02-20 Thread Barbie
On Sun, Feb 19, 2006 at 10:22:20PM +1100, Adam Kennedy wrote: > > 2. Incompatible packaging. > Packaging unwraps, but missing files for the testing scheme. You may want to split this into a result that contains no test suite at all (UNKNOWN) and one that has missing files according to the M

Re: Request for Comments: Package testing results analysis, result codes

2006-02-19 Thread Adam Kennedy
(Andreas J. Koenig) wrote: On Sun, 19 Feb 2006 22:22:20 +1100, Adam Kennedy <[EMAIL PROTECTED]> said: > 1. Broken or corrupt packaging. > A bad tarball, MANIFEST files missing. Make sure you verify that all files in the distro are readable. Reject if the permissions are bogus. Recentl

Re: Request for Comments: Package testing results analysis, result codes

2006-02-19 Thread Adam Kennedy
While an interesting idea, I forsee two challenges to doing this... Firstly is that it might turn an otherwise normal result into something else, with no clear rule. It makes a judgement call that some level of testing is good or bad, which isn't really the place of an installer to call. The

Re: Request for Comments: Package testing results analysis, result codes

2006-02-19 Thread Sébastien Aperghis-Tramoni
Tyler MacDonald wrote: Tests run, but >50% (or maybe >80%?) are skipped. From what I've seen, the most common cause of this is that the package is untestable with the current build configuration. Eg; you needed to specify a webserver or database or something to get these tests

Re: Request for Comments: Package testing results analysis, result codes

2006-02-19 Thread Michael Graham
Tyler MacDonald <[EMAIL PROTECTED]> wrote: > Adam, > I have one more edgey case I'd like to see on this list: > Tests run, but >50% (or maybe >80%?) are skipped. > > From what I've seen, the most common cause of this is that the > package is untestable with the current build

Re: Request for Comments: Package testing results analysis, result codes

2006-02-19 Thread Tyler MacDonald
Adam, I have one more edgey case I'd like to see on this list: > > 13. Tests exist, but fail to be executed. > There is tests, but the tests themselves aren't failing. > It's the build-process that is failing. > > 14. Tests run, and some/all tests fail. > The normal FAIL case

Re: Request for Comments: Package testing results analysis, result codes

2006-02-19 Thread Andreas J. Koenig
> On Sun, 19 Feb 2006 22:22:20 +1100, Adam Kennedy <[EMAIL PROTECTED]> said: > 1. Broken or corrupt packaging. > A bad tarball, MANIFEST files missing. Make sure you verify that all files in the distro are readable. Reject if the permissions are bogus. Recently we had an increasig nu

Request for Comments: Package testing results analysis, result codes

2006-02-19 Thread Adam Kennedy
I'm starting to get a bit closer (waiting on a test images and some last testing to be done) to finishing the initial PITA test cycle (and thus be able to do an initial release) and so I'm starting to do some prep work now for the next stage, which is to start to assemble some infrastructure ar