Re: ok(1,1) vs. ok ('foo','foo') in Test::More

2004-02-03 Thread Michael G Schwern
On Tue, Feb 03, 2004 at 08:41:13PM +, Fergal Daly wrote: > package MyModule::OKSwapper; > > require Test::More; > require Exporter; > @ISA = qw( Exporter); > @EXPORT= qw( ok ); > > sub ok > { > @_ = 1; > goto &Test::More::ok; > } > > Then, when you fix all the ok()s in a file, ju

Re: ok(1,1) vs. ok ('foo','foo') in Test::More

2004-02-03 Thread Tels
-BEGIN PGP SIGNED MESSAGE- Moin, On Tuesday 03 February 2004 19:08, Adrian Howard wrote: > On Tuesday, February 3, 2004, at 05:44 pm, Tels wrote: > [snip] > > > This has prevented me from "converting" several huge old testsuites > > from > > "use Test;" to "use Test::More;" because I kno

Re: ok(1,1) vs. ok ('foo','foo') in Test::More

2004-02-03 Thread chromatic
On Tue, 2004-02-03 at 12:46, Tels wrote: > I still think a big warning should be added to Test::More beeing _not_ a > drop-in replacement to Test. I can only remember calling it a drop-in replacement for Test::Simple. -- c

Re: ok(1,1) vs. ok ('foo','foo') in Test::More

2004-02-03 Thread Tels
-BEGIN PGP SIGNED MESSAGE- Moin, On Tuesday 03 February 2004 21:41, Fergal Daly wrote: > > If I could just change "Test;" to "Test::More;" without hundreds of > > warnings springing on me I know I would convert the test scripts and > > then change them step by step over to the new code (o

Re: ok(1,1) vs. ok ('foo','foo') in Test::More

2004-02-03 Thread Fergal Daly
> If I could just change "Test;" to "Test::More;" without hundreds of warnings > springing on me I know I would convert the test scripts and then change > them step by step over to the new code (or not change them at all, because > don't change working code..) If you don't mind adding a use My

Re: ok(1,1) vs. ok ('foo','foo') in Test::More

2004-02-03 Thread Fergal Daly
On Tuesday 03 February 2004 20:46, Tels wrote: > PS: Thanx for your suggestion, but what exactly does this do: > > sub ok > { > @_ = 1; > goto &Test::More::ok; > } > > Pass a single (1), or only the first argument? *puzzled* It passes a single (1) :-( It should be $#_ = 0; I go

Re: ok(1,1) vs. ok ('foo','foo') in Test::More

2004-02-03 Thread Tels
-BEGIN PGP SIGNED MESSAGE- Moin, On Tuesday 03 February 2004 19:26, Andy Lester wrote: > On Tue, Feb 03, 2004 at 06:44:04PM +0100, Tels ([EMAIL PROTECTED]) wrote: > > is there a re reason that the following warns: > > > > % perl -MTest::More -le 'plan tests => 1; ok (1,1)' > > 1.

Re: ok(1,1) vs. ok ('foo','foo') in Test::More

2004-02-03 Thread Andy Lester
On Tue, Feb 03, 2004 at 06:44:04PM +0100, Tels ([EMAIL PROTECTED]) wrote: > is there a re reason that the following warns: > > % perl -MTest::More -le 'plan tests => 1; ok (1,1)' > 1..1 > # You named your test '1'. You shouldn't use numbers for your test >names. >

Re: ok(1,1) vs. ok ('foo','foo') in Test::More

2004-02-03 Thread Adrian Howard
On Tuesday, February 3, 2004, at 05:44 pm, Tels wrote: [snip] This has prevented me from "converting" several huge old testsuites from "use Test;" to "use Test::More;" because I know that I would then have to go and add testnames to thousand of tests (e.g. all tests that test for number output).

ok(1,1) vs. ok ('foo','foo') in Test::More

2004-02-03 Thread Tels
-BEGIN PGP SIGNED MESSAGE- Moin, is there a re reason that the following warns: % perl -MTest::More -le 'plan tests => 1; ok (1,1)' 1..1 # You named your test '1'. You shouldn't use numbers for your test names. # Very confusing. and this