Re: thinking about variable context for like()

2003-11-17 Thread Rafael Garcia-Suarez
Potozniak, Andrew wrote: > > I would suggest something along the lines of: > > &like_html(actual_value, expected_regex, max_chars_to_output, > string_description); In fact I think that making max_chars_to_output a global configuration variable is a better option, because repeating it (if yo

Re: Refactoring a test program: advice sought

2003-11-17 Thread darren chamberlain
* Andrew Savige [2003-11-15 14:51]: > I took a quick look a mod_perl and Template Toolkit (TT). > TT has a: > lib/Template/Test.pm > which looks wrong to me (should that not be under t/lib instead?). Template::Test contains a bunch of (pre-Test::More) testing methods that are geared towards wri

RE: thinking about variable context for like()

2003-11-17 Thread Potozniak, Andrew
Maybe I'm off with my next comment and maybe I'm not but here it goes: What you're suggesting is a difference between mechanizm and policy. We want a function that will be just like Test::More::like, but we want it to only output a certain amount of chars because frankly we don't want to see all

RE: thinking about variable context for like()

2003-11-17 Thread chromatic
On Mon, 2003-11-17 at 06:54, Potozniak, Andrew wrote: > What's stopping you from creating this global var > and passing it in to the function whenever it is called? Good taste. If it's going to be more convenient than Test::More's like(), go all the way and make it more convenient. > Or you cou

Re: thinking about variable context for like()

2003-11-17 Thread Rafael Garcia-Suarez
Chromatic wrote in perl.qa : > On Mon, 2003-11-17 at 06:54, Potozniak, Andrew wrote: > >> What's stopping you from creating this global var >> and passing it in to the function whenever it is called? > > Good taste. If it's going to be more convenient than Test::More's > like(), go all the way a

Re: Refactoring a test program: advice sought

2003-11-17 Thread Dave Rolsky
On Mon, 17 Nov 2003, darren chamberlain wrote: > * Andrew Savige [2003-11-15 14:51]: > > I took a quick look a mod_perl and Template Toolkit (TT). > > TT has a: > > lib/Template/Test.pm > > which looks wrong to me (should that not be under t/lib instead?). > > Template::Test contains a bunch of

Re: thinking about variable context for like()

2003-11-17 Thread Rafael Garcia-Suarez
FWIW, I uploaded Test::LongString 0.03 to CPAN. It implements like_string() and unlike_string(), and also : > (That's why I can imagine accepting the default length as an argument > to Test::LongString::import().)