On Mon, Nov 19, 2001 at 10:36:45PM +0100, Tels wrote:
> > sub canonpath {
> > return File::Spec->canonpath($_[1]);
> > }
>
> I'd written return File::Spec->canonpath(@_); just in case ;)
The first argument has to be ignored (it's the MakeMaker object)
and canonpath() takes just one argument.
The rest you'll have to do on a case-by-case basis. Don't get fancy.
As for the testing, just ensure that:
is( ExtUtils::MM_Unix->canonpath($foo), File::Spec->canonpath($foo) );
that should be sufficient.
> > This also means you can completely junk all the versions of these
> > methods in the subclasses. Anything that reduces the size of
> > MakeMaker has to be a good thing.
>
> Thought so. ;o) I assume this patch needs also to Cced to were the
> official makemaker lives? CPAN? (Note to self: Check this tomorrow)
The core contains the only official version of MakeMaker. I tried to
move it to CPAN a few months ago, but got scared because of the lack
of tests. There's an alpha still sitting in my CPAN author directory.
Kurt was supposed to give this another whack.
Just forward them to [EMAIL PROTECTED]
--
Michael G. Schwern <[EMAIL PROTECTED]> http://www.pobox.com/~schwern/
Perl Quality Assurance <[EMAIL PROTECTED]> Kwalitee Is Job One
WOOHOO! I'm going to Disneyland!
http://www.goats.com/archive/980805.html
