installhtml needs a good beating out

2001-10-19 Thread Michael G Schwern
"beating out" like you beat out a rug. Constructive, and still has the satisfying feeling of clubbing something with sticks. Anyhow, I just had a look inside installhtml and eeewww. So if anyone's got some spare time they can do a little refactoring of installhtml. Nothing fancy if it's done i

Re: installhtml needs a good beating out

2001-10-20 Thread Rafael Garcia-Suarez
On 2001.10.20 17:16 Jarkko Hietaniemi wrote: > On Sat, Oct 20, 2001 at 02:02:59AM -0400, Michael G Schwern wrote: > > > > > > I think installhtml teeters heavily on the brink of "Rewriting" > > > instead of "Refactoring". It hasn't changed much since 1997. > > > > Refactoring is just rewriting

Re: installhtml needs a good beating out

2001-10-19 Thread Jarkko Hietaniemi
> Once you've done that you can add "Refactoring" to the list of > buzzwords on your resume. :) I think installhtml teeters heavily on the brink of "Rewriting" instead of "Refactoring". It hasn't changed much since 1997. -- $jhi++; # http://www.iki.fi/jhi/ # There is this special biolo

Re: installhtml needs a good beating out

2001-10-19 Thread Michael G Schwern
On Sat, Oct 20, 2001 at 08:58:11AM +0300, Jarkko Hietaniemi wrote: > > Once you've done that you can add "Refactoring" to the list of > > buzzwords on your resume. :) > > I think installhtml teeters heavily on the brink of "Rewriting" > instead of "Refactoring". It hasn't changed much since 1997

Re: installhtml needs a good beating out

2001-10-20 Thread Jarkko Hietaniemi
On Sat, Oct 20, 2001 at 02:02:59AM -0400, Michael G Schwern wrote: > On Sat, Oct 20, 2001 at 08:58:11AM +0300, Jarkko Hietaniemi wrote: > > > Once you've done that you can add "Refactoring" to the list of > > > buzzwords on your resume. :) > > > > I think installhtml teeters heavily on the brink

[REPATCH installhtml] Re: installhtml needs a good beating out

2001-10-20 Thread chromatic
In article <[EMAIL PROTECTED]>, "Johan Vromans" <[EMAIL PROTECTED]> wrote: > I'm not sure what you are trying to achieve with this. Really really small incremental changes? > The net efffect is that you get something like > > GetOptions('foo' => \$Options{foo}, 'bar=s' => \$Options{bar}

[proposed PATCH installhtml] Re: installhtml needs a good beating out

2001-10-20 Thread chromatic
In article <20011020014825.J3681@blackrider>, "Michael G Schwern" <[EMAIL PROTECTED]> wrote: > Convert from $opt_* globals to an %Options hash A fun use of map! Is there a test for this beast? A quick 'perl -wc installhtml' verified that it compiles, but refactoring's half complete without

Re: [REPATCH installhtml] Re: installhtml needs a good beating out

2001-10-22 Thread chromatic
In article <[EMAIL PROTECTED]>, "Benjamin Goldberg" <[EMAIL PROTECTED]> wrote: > Chromatic wrote: > [snip] >> sub parse_command_line { >> -usage() if defined $opt_help; >> -$opt_help = "";# make -w shut up +usage() if defined >> $Options{help}; >> +$Options{help}

Re: [REPATCH installhtml] Re: installhtml needs a good beating out

2001-10-22 Thread Benjamin Goldberg
Chromatic wrote: [snip] > sub parse_command_line { > -usage() if defined $opt_help; > -$opt_help = "";# make -w shut up > +usage() if defined $Options{help}; > +$Options{help} = ""; # make -w shut up Isn't that "make -w shut up" is talking about

Re: [proposed PATCH installhtml] Re: installhtml needs a good beating out

2001-10-20 Thread Jarkko Hietaniemi
On Sat, Oct 20, 2001 at 04:25:02PM -0400, Michael G Schwern wrote: > On Sat, Oct 20, 2001 at 06:25:20PM +0300, Jarkko Hietaniemi wrote: > > You have been drinking deeply from the fount of the QA Kool-Aid, > > haven't you? I'm probably not going to be surprised one day to > > find a regression tes

Re: [proposed PATCH installhtml] Re: installhtml needs a good beating out

2001-10-20 Thread Michael G Schwern
On Sat, Oct 20, 2001 at 06:25:20PM +0300, Jarkko Hietaniemi wrote: > You have been drinking deeply from the fount of the QA Kool-Aid, > haven't you? I'm probably not going to be surprised one day to > find a regression test for Configure waiting in my inbox. Would you mind it if you did? ;) --

Re: [proposed PATCH installhtml] Re: installhtml needs a good beating out

2001-10-20 Thread Jarkko Hietaniemi
On Sat, Oct 20, 2001 at 01:54:14AM -0600, chromatic wrote: > In article <20011020014825.J3681@blackrider>, "Michael G Schwern" > <[EMAIL PROTECTED]> wrote: > > > Convert from $opt_* globals to an %Options hash > > A fun use of map! > > Is there a test for this beast? A quick 'perl -wc inst

Re: [proposed PATCH installhtml] Re: installhtml needs a good beating out

2001-10-20 Thread Johan Vromans
> # parse the command-line > -my $result = GetOptions( qw( > +my $result = GetOptions( map { > + my $key = $_; > + $key =~ s/\W.+$//; > + $key => \$Options{$_}; > +} qw( > help > podpath=s > podroot=s I'm not sure what you are trying to a