Hello.
With Perl 5.8.0 RC2 (or plus Change 17353),
there is something strange.
In $unicode =~ s/$regex/$bytes/,
$bytes is not upgraded,
and a malformed Unicode string is generated.
$unicode =~ s/$regex/$bytes/e is ok, though.
E.g.,
#!perl
$a = "\x{100}\x{101}";
$a =~ s/\x{101}/\xFF/
Groan. It doesn't seem that people have been stress testing Unicode
s/// so far that much. But anyway, another fix attached, along with
the previous one.
--
$jhi++; # http://www.iki.fi/jhi/
# There is this special biologist word we use for 'stable'.
# It is 'dead'. -- Jack Cohe
Mopping up.
Change 17362 by jhi@alpha on 2002/06/26 15:25:45
Let's not leak.
Affected files ...
//depot/perl/pp_hot.c#283 edit
Differences ...
//depot/perl/pp_hot.c#283 (text)
Index: perl/pp_hot.c
--- perl/pp_hot.c#282~17358~Wed Jun 26 17:37:12 2002
+++ perl/pp_hot
SADAHIRO Tomoyuki <[EMAIL PROTECTED]> wrote:
:With Perl 5.8.0 RC2 (or plus Change 17353),
:there is something strange.
:
:In $unicode =~ s/$regex/$bytes/,
:$bytes is not upgraded,
:and a malformed Unicode string is generated.
:
:$unicode =~ s/$regex/$bytes/e is ok, though.
As far as I can tell, t
I wrote:
:Attached patch passes all existing tests here, as well as some new ones.
Whoops, crossed in the post. My patch was written against @17356;
it may not be necessary after #17358, but the extra tests might be
worth keeping.
I notice that you've used this code:
SV *nsv = newSVpvn(c, cl
On Wed, Jun 26, 2002 at 05:43:07PM +0100, Hugo van der Sanden wrote:
> SADAHIRO Tomoyuki <[EMAIL PROTECTED]> wrote:
> :With Perl 5.8.0 RC2 (or plus Change 17353),
> :there is something strange.
> :
> :In $unicode =~ s/$regex/$bytes/,
> :$bytes is not upgraded,
> :and a malformed Unicode string is
On Wed, Jun 26, 2002 at 05:52:25PM +0100, Hugo van der Sanden wrote:
> I wrote:
> :Attached patch passes all existing tests here, as well as some new ones.
>
> Whoops, crossed in the post. My patch was written against @17356;
> it may not be necessary after #17358, but the extra tests might be
>
> > Also, does your version need the additional
> > SvSetMagicSV(nsv, dstr)
>
> Probably. I'll try whether it disturbs anything, I guess no since
> we'd need some magical Unicode string?
Doesn't seem to hurt, but before I have a test case that exercises
that piece of code, I'd rather not ad
