Re: why does perl critic not like @_

2014-08-21 Thread Gabor Szabo
I've never seen people using @_ as some kind of a temporary variable and I think this practice should be discouraged. Probably Perl::Critic should have a policy finding and reporting such cases as this is just confusing. @_ is a special variable to receive function parameters. Gabor http://perlmav

Re: why does perl critic not like @_

2014-08-19 Thread Robert W Weaver
John wrote: > I have just started using perl critic to analyse my code. > > I have often used @_ as a temporary array like this: [..] > Critic complains with 'Always unpack @_ first', why? > What is so wrong with this usage? anthony.okusa...@usbank.com gave an excellent response to what perl crit

Re: why does perl critic not like @_

2014-08-18 Thread anthony . okusanya
e. For example: The main point is to help you write readable code :) From: John To: perl-win32-users@listserv.ActiveState.com, Date: 08/18/2014 11:51 PM Subject: why does perl critic not like @_ Sent by:perl-win32-users-boun...@listserv.activestate.com Hi I have jus

why does perl critic not like @_

2014-08-18 Thread John
Hi I have just started using perl critic to analyse my code. I have often used @_ as a temporary array like this: [code] # count internals @_ = $h_wk->selectrow_array("SELECT COUNT(*) FROM v_internals"); my $count_all_internals = shift @_; @_ = $h_wk->selectrow_array("SELECT COUN