Re: MARC::Record tests and MicroLIF.pm

2005-01-10 Thread Ed Summers
On Thu, Jan 06, 2005 at 10:03:13PM -0600, Bryan Baldus wrote: Is there any problem with committing the revised version of MARC::File::USMARC, and adding+committing the three files above to cvs in the t/ directory? Nice work :) as long as the tests pass I think comitting sounds like a good

Re: MARC::Record tests

2005-01-06 Thread Ed Summers
I'm thinking that the MicroLIF failure is due to line endings being different on Mac versions OS X. There is code in MARC::File::MicroLIF::_get_chunk that handles DOS (\r\n) and Unix (\n) line endings, but not Mac (\r). Does anyone know if \r is a legit line ending in MicroLIF? //Ed

RE: MARC::Record tests

2005-01-06 Thread Bryan Baldus
There is code in MARC::File::MicroLIF::_get_chunk that handles DOS (\r\n) and Unix (\n) line endings, but not Mac (\r). This is true, and it seems to work. Unfortunately, it is not reached by the test, since the test calls decode() directly, instead of going through _next() or _get_chunk.