Branch: refs/heads/davem/refactor_warnings_pl Home: https://github.com/Perl/perl5 Commit: b4b8bc790e0c34907a17949330209db25b4c3e86 https://github.com/Perl/perl5/commit/b4b8bc790e0c34907a17949330209db25b4c3e86 Author: David Mitchell <da...@iabyn.com> Date: 2022-04-25 (Mon, 25 Apr 2022)
Changed paths: M regen/warnings.pl Log Message: ----------- regen/warnings.pl: move boilerplate text to end Move a couple of large chunks of <<'EOF' code text to the end of the file (but before __END__) to make the flow of code easier to see. The output generated is unchanged. Commit: a2a347b4ae408533934ac5d44dea079d68f3888a https://github.com/Perl/perl5/commit/a2a347b4ae408533934ac5d44dea079d68f3888a Author: David Mitchell <da...@iabyn.com> Date: 2022-04-25 (Mon, 25 Apr 2022) Changed paths: M regen/warnings.pl Log Message: ----------- regen/warnings.pl: remove unused lexical variable $offset was added in 2000, but hasn't actually been used for a long while Commit: 924b79ec894a646d887fcb2a608b24cc5f6b70dc https://github.com/Perl/perl5/commit/924b79ec894a646d887fcb2a608b24cc5f6b70dc Author: David Mitchell <da...@iabyn.com> Date: 2022-04-25 (Mon, 25 Apr 2022) Changed paths: M regen/warnings.pl Log Message: ----------- regen/warnings.pl: remove a block scope A block of code no longer declares any lexical variables, so remove the block. Apart from removing a '{' and '}', this is a whitespace-only change. Commit: 28566b6c37e1a8e35b6653b80fb914fb321fa83b https://github.com/Perl/perl5/commit/28566b6c37e1a8e35b6653b80fb914fb321fa83b Author: David Mitchell <da...@iabyn.com> Date: 2022-04-25 (Mon, 25 Apr 2022) Changed paths: M regen/warnings.pl Log Message: ----------- regen/warnings.pl: uppercase 'global' lexical vars various lexical vars like $tree, $def are populated early on, then their values are used later in many places, including directly in subs. Rename these vars to be uppercase and with more meaningful names, to emphasise their globalness. (Ideally they really ought to be local and passed as arguments to all the subs that use them, but that's more work.) Commit: e199ccbe7dad0b1473a23edfad11956ed9d8cc73 https://github.com/Perl/perl5/commit/e199ccbe7dad0b1473a23edfad11956ed9d8cc73 Author: David Mitchell <da...@iabyn.com> Date: 2022-04-25 (Mon, 25 Apr 2022) Changed paths: M regen/warnings.pl Log Message: ----------- regen/warnings.pl: eliminate lexical var %Value This doesn't seem to be used any more Commit: ddb832e76a78bb005fae572b51427c5dc52a7e4f https://github.com/Perl/perl5/commit/ddb832e76a78bb005fae572b51427c5dc52a7e4f Author: David Mitchell <da...@iabyn.com> Date: 2022-04-25 (Mon, 25 Apr 2022) Changed paths: M regen/warnings.pl Log Message: ----------- regen/warnings.pl: eliminate global %v_list var This lexical had global scope. Instead, make it a parameter to sub valueWalk(), since it;s on;y used temporarily by two subs. Commit: efea5060e647ef90a9dc950e7be5cbebe25f73df https://github.com/Perl/perl5/commit/efea5060e647ef90a9dc950e7be5cbebe25f73df Author: David Mitchell <da...@iabyn.com> Date: 2022-04-25 (Mon, 25 Apr 2022) Changed paths: M regen/warnings.pl Log Message: ----------- regen/warnings.pl: eliminate broken dup check orderValues() checks for a duplicate warnings name. However, 1) This is also done in walk(), so is redundant. 2) It is broken. Originally it declared @list but checked %list; %list is global and was renamed to %CATEGORIES to make it clear it was a global (and thus unrelated to @list). So its probably never worked. Commit: 255d73911d45bcf09bd041bd548ccb166202720a https://github.com/Perl/perl5/commit/255d73911d45bcf09bd041bd548ccb166202720a Author: David Mitchell <da...@iabyn.com> Date: 2022-04-25 (Mon, 25 Apr 2022) Changed paths: M regen/warnings.pl Log Message: ----------- regen/warnings.pl: better comment what the subs do Commit: 2f696ff0b3fe16b9bb16045fb5c71bcf8e041895 https://github.com/Perl/perl5/commit/2f696ff0b3fe16b9bb16045fb5c71bcf8e041895 Author: David Mitchell <da...@iabyn.com> Date: 2022-04-25 (Mon, 25 Apr 2022) Changed paths: M regen/warnings.pl Log Message: ----------- regen/warnings.p: rename filehandle variables rename my($warn, $pm) to ($warn_h, $warn_pm) to make it easier to see that they're the filehandles for warnings.h and warnings.pm Commit: 9f1f50dd1323de7f3f3acb60235e99ffde9544d3 https://github.com/Perl/perl5/commit/9f1f50dd1323de7f3f3acb60235e99ffde9544d3 Author: David Mitchell <da...@iabyn.com> Date: 2022-04-25 (Mon, 25 Apr 2022) Changed paths: M regen/warnings.pl Log Message: ----------- regen/warnings.pl: add comments about $TREE Explain this structure, which is the input used to define all the warnings. Compare: https://github.com/Perl/perl5/compare/b4b8bc790e0c%5E...9f1f50dd1323