On Fri, Apr 26, 2002 at 12:46:22PM -0500, Craig A. Berry wrote: > lib/Test/Harness/t/strap-analyze....FAILED at test 9 > lib/Test/Harness/t/test-harness.....FAILED at test 17 > Failed 3 test scripts out of 616, 99.51% okay. > > The new Test::Harness looks like it has some problems related to exit > statuses.
Yep. It's just VMS's funny exit codes which I forgot to take into account. This'll fix it. (It looks big, but 98% of it is just reindentation). --- test-harness.t 26 Apr 2002 05:12:28 -0000 1.9 +++ test-harness.t 26 Apr 2002 18:00:43 -0000 @@ -35,341 +35,341 @@ use Test::More; -use vars qw($Total_tests %samples); +my $IsVMS = $^O eq 'VMS'; -plan tests => $Total_tests; -use Test::Harness; -use_ok('Test::Harness'); +my $die_estat = $IsVMS ? 4 : 1; +my $die_wstat = $die_estat * 256; + +my %samples = ( + simple => { + total => { + bonus => 0, + max => 5, + 'ok' => 5, + files => 1, + bad => 0, + good => 1, + tests => 1, + sub_skipped=> 0, + 'todo' => 0, + skipped => 0, + }, + failed => { }, + all_ok => 1, + }, + simple_fail => { + total => { + bonus => 0, + max => 5, + 'ok' => 3, + files => 1, + bad => 1, + good => 0, + tests => 1, + sub_skipped => 0, + 'todo' => 0, + skipped => 0, + }, + failed => { + canon => '2 5', + }, + all_ok => 0, + }, + descriptive => { + total => { + bonus => 0, + max => 5, + 'ok' => 5, + files => 1, + bad => 0, + good => 1, + tests => 1, + sub_skipped=> 0, + 'todo' => 0, + skipped => 0, + }, + failed => { }, + all_ok => 1, + }, + no_nums => { + total => { + bonus => 0, + max => 5, + 'ok' => 4, + files => 1, + bad => 1, + good => 0, + tests => 1, + sub_skipped=> 0, + 'todo' => 0, + skipped => 0, + }, + failed => { + canon => '3', + }, + all_ok => 0, + }, + 'todo' => { + total => { + bonus => 1, + max => 5, + 'ok' => 5, + files => 1, + bad => 0, + good => 1, + tests => 1, + sub_skipped=> 0, + 'todo' => 2, + skipped => 0, + }, + failed => { }, + all_ok => 1, + }, + todo_inline => { + total => { + bonus => 1, + max => 3, + 'ok' => 3, + files => 1, + bad => 0, + good => 1, + tests => 1, + sub_skipped => 0, + 'todo' => 2, + skipped => 0, + }, + failed => { }, + all_ok => 1, + }, + 'skip' => { + total => { + bonus => 0, + max => 5, + 'ok' => 5, + files => 1, + bad => 0, + good => 1, + tests => 1, + sub_skipped=> 1, + 'todo' => 0, + skipped => 0, + }, + failed => { }, + all_ok => 1, + }, + bailout => 0, + combined => { + total => { + bonus => 1, + max => 10, + 'ok' => 8, + files => 1, + bad => 1, + good => 0, + tests => 1, + sub_skipped=> 1, + 'todo' => 2, + skipped => 0 + }, + failed => { + canon => '3 9', + }, + all_ok => 0, + }, + duplicates => { + total => { + bonus => 0, + max => 10, + 'ok' => 11, + files => 1, + bad => 1, + good => 0, + tests => 1, + sub_skipped=> 0, + 'todo' => 0, + skipped => 0, + }, + failed => { + canon => '??', + }, + all_ok => 0, + }, + head_end => { + total => { + bonus => 0, + max => 4, + 'ok' => 4, + files => 1, + bad => 0, + good => 1, + tests => 1, + sub_skipped=> 0, + 'todo' => 0, + skipped => 0, + }, + failed => { }, + all_ok => 1, + }, + head_fail => { + total => { + bonus => 0, + max => 4, + 'ok' => 3, + files => 1, + bad => 1, + good => 0, + tests => 1, + sub_skipped=> 0, + 'todo' => 0, + skipped => 0, + }, + failed => { + canon => '2', + }, + all_ok => 0, + }, + skip_all => { + total => { + bonus => 0, + max => 0, + 'ok' => 0, + files => 1, + bad => 0, + good => 1, + tests => 1, + sub_skipped=> 0, + 'todo' => 0, + skipped => 1, + }, + failed => { }, + all_ok => 1, + }, + with_comments => { + total => { + bonus => 2, + max => 5, + 'ok' => 5, + files => 1, + bad => 0, + good => 1, + tests => 1, + sub_skipped=> 0, + 'todo' => 4, + skipped => 0, + }, + failed => { }, + all_ok => 1, + }, + taint => { + total => { + bonus => 0, + max => 1, + 'ok' => 1, + files => 1, + bad => 0, + good => 1, + tests => 1, + sub_skipped=> 0, + 'todo' => 0, + skipped => 0, + }, + failed => { }, + all_ok => 1, + }, + 'die' => { + total => { + bonus => 0, + max => 0, + 'ok' => 0, + files => 1, + bad => 1, + good => 0, + tests => 1, + sub_skipped=> 0, + 'todo' => 0, + skipped => 0, + }, + failed => { + estat => $die_estat, + wstat => $die_wstat, + max => '??', + failed => '??', + canon => '??', + }, + all_ok => 0, + }, -BEGIN { - %samples = ( - simple => { - total => { - bonus => 0, - max => 5, - 'ok' => 5, - files => 1, - bad => 0, - good => 1, - tests => 1, - sub_skipped=> 0, - 'todo' => 0, - skipped => 0, - }, - failed => { }, - all_ok => 1, - }, - simple_fail => { - total => { - bonus => 0, - max => 5, - 'ok' => 3, - files => 1, - bad => 1, - good => 0, - tests => 1, - sub_skipped => 0, - 'todo' => 0, - skipped => 0, - }, - failed => { - canon => '2 5', - }, - all_ok => 0, - }, - descriptive => { - total => { - bonus => 0, - max => 5, - 'ok' => 5, - files => 1, - bad => 0, - good => 1, - tests => 1, - sub_skipped=> 0, - 'todo' => 0, - skipped => 0, - }, - failed => { }, - all_ok => 1, - }, - no_nums => { - total => { - bonus => 0, - max => 5, - 'ok' => 4, - files => 1, - bad => 1, - good => 0, - tests => 1, - sub_skipped=> 0, - 'todo' => 0, - skipped => 0, - }, - failed => { - canon => '3', - }, - all_ok => 0, - }, - 'todo' => { - total => { - bonus => 1, - max => 5, - 'ok' => 5, - files => 1, - bad => 0, - good => 1, - tests => 1, - sub_skipped=> 0, - 'todo' => 2, - skipped => 0, - }, - failed => { }, - all_ok => 1, - }, - todo_inline => { - total => { - bonus => 1, - max => 3, - 'ok' => 3, - files => 1, - bad => 0, - good => 1, - tests => 1, - sub_skipped => 0, - 'todo' => 2, - skipped => 0, - }, - failed => { }, - all_ok => 1, - }, - 'skip' => { - total => { - bonus => 0, - max => 5, - 'ok' => 5, - files => 1, - bad => 0, - good => 1, - tests => 1, - sub_skipped=> 1, - 'todo' => 0, - skipped => 0, - }, - failed => { }, - all_ok => 1, - }, - bailout => 0, - combined => { - total => { - bonus => 1, - max => 10, - 'ok' => 8, - files => 1, - bad => 1, - good => 0, - tests => 1, - sub_skipped=> 1, - 'todo' => 2, - skipped => 0 - }, - failed => { - canon => '3 9', - }, - all_ok => 0, - }, - duplicates => { - total => { - bonus => 0, - max => 10, - 'ok' => 11, - files => 1, - bad => 1, - good => 0, - tests => 1, - sub_skipped=> 0, - 'todo' => 0, - skipped => 0, - }, - failed => { - canon => '??', - }, - all_ok => 0, - }, - head_end => { - total => { - bonus => 0, - max => 4, - 'ok' => 4, - files => 1, - bad => 0, - good => 1, - tests => 1, - sub_skipped=> 0, - 'todo' => 0, - skipped => 0, - }, - failed => { }, - all_ok => 1, - }, - head_fail => { - total => { - bonus => 0, - max => 4, - 'ok' => 3, - files => 1, - bad => 1, - good => 0, - tests => 1, - sub_skipped=> 0, - 'todo' => 0, - skipped => 0, - }, - failed => { - canon => '2', - }, - all_ok => 0, - }, - skip_all => { - total => { - bonus => 0, - max => 0, - 'ok' => 0, - files => 1, - bad => 0, - good => 1, - tests => 1, - sub_skipped=> 0, - 'todo' => 0, - skipped => 1, - }, - failed => { }, - all_ok => 1, - }, - with_comments => { - total => { - bonus => 2, - max => 5, - 'ok' => 5, - files => 1, - bad => 0, - good => 1, - tests => 1, - sub_skipped=> 0, - 'todo' => 4, - skipped => 0, - }, - failed => { }, - all_ok => 1, - }, - taint => { - total => { - bonus => 0, - max => 1, - 'ok' => 1, - files => 1, - bad => 0, - good => 1, - tests => 1, - sub_skipped=> 0, - 'todo' => 0, - skipped => 0, - }, - failed => { }, - all_ok => 1, - }, + die_head_end => { + total => { + bonus => 0, + max => 0, + 'ok' => 4, + files => 1, + bad => 1, + good => 0, + tests => 1, + sub_skipped=> 0, + 'todo' => 0, + skipped => 0, + }, + failed => { + estat => $die_estat, + wstat => $die_wstat, + max => '??', + failed => '??', + canon => '??', + }, + all_ok => 0, + }, - 'die' => { - total => { - bonus => 0, - max => 0, - 'ok' => 0, - files => 1, - bad => 1, - good => 0, - tests => 1, - sub_skipped=> 0, - 'todo' => 0, - skipped => 0, - }, - failed => { - estat => 1, - wstat => 256, - max => '??', - failed => '??', - canon => '??', - }, - all_ok => 0, - }, + die_last_minute => { + total => { + bonus => 0, + max => 4, + 'ok' => 4, + files => 1, + bad => 1, + good => 0, + tests => 1, + sub_skipped=> 0, + 'todo' => 0, + skipped => 0, + }, + failed => { + estat => $die_estat, + wstat => $die_wstat, + max => 4, + failed => 0, + canon => '??', + }, + all_ok => 0, + }, + bignum => { + total => { + bonus => 0, + max => 2, + 'ok' => 4, + files => 1, + bad => 1, + good => 0, + tests => 1, + sub_skipped=> 0, + 'todo' => 0, + skipped => 0, + }, + failed => { + canon => '??', + }, + all_ok => 0, + }, + ); - die_head_end => { - total => { - bonus => 0, - max => 0, - 'ok' => 4, - files => 1, - bad => 1, - good => 0, - tests => 1, - sub_skipped=> 0, - 'todo' => 0, - skipped => 0, - }, - failed => { - estat => 1, - wstat => 256, - max => '??', - failed => '??', - canon => '??', - }, - all_ok => 0, - }, +plan tests => (keys(%samples) * 4) + 1; - die_last_minute => { - total => { - bonus => 0, - max => 4, - 'ok' => 4, - files => 1, - bad => 1, - good => 0, - tests => 1, - sub_skipped=> 0, - 'todo' => 0, - skipped => 0, - }, - failed => { - estat => 1, - wstat => 256, - max => 4, - failed => 0, - canon => '??', - }, - all_ok => 0, - }, - bignum => { - total => { - bonus => 0, - max => 2, - 'ok' => 4, - files => 1, - bad => 1, - good => 0, - tests => 1, - sub_skipped=> 0, - 'todo' => 0, - skipped => 0, - }, - failed => { - canon => '??', - }, - all_ok => 0, - }, - ); +use Test::Harness; +use_ok('Test::Harness'); - $Total_tests = (keys(%samples) * 4) + 1; -} tie *NULL, 'My::Dev::Null' or die $!; --- strap-analyze.t 26 Apr 2002 05:12:28 -0000 1.2 +++ strap-analyze.t 26 Apr 2002 17:57:55 -0000 @@ -20,6 +20,9 @@ my $IsVMS = $^O eq 'VMS'; +my $die_exit = $IsVMS ? 4 : 1; +my $die_wait = $die_exit * 256; + my %samples = ( combined => { passing => 0, @@ -308,8 +311,8 @@ 'die' => { passing => 0, - 'exit' => 1, - 'wait' => 256, + 'exit' => $die_exit, + 'wait' => $die_wait, max => 0, seen => 0, @@ -325,8 +328,8 @@ die_head_end => { passing => 0, - 'exit' => 1, - 'wait' => 256, + 'exit' => $die_exit, + 'wait' => $die_wait, max => 0, seen => 4, @@ -343,8 +346,8 @@ die_last_minute => { passing => 0, - 'exit' => 1, - 'wait' => 256, + 'exit' => $die_exit, + 'wait' => $die_wait, max => 4, seen => 4, @@ -391,5 +394,5 @@ delete $expect->{details}; delete $results{details}; - is_deeply(\%results, $expect, " the rest" ); + is_deeply(\%results, $expect, " the rest $test" ); } -- Michael G. Schwern <[EMAIL PROTECTED]> http://www.pobox.com/~schwern/ Perl Quality Assurance <[EMAIL PROTECTED]> Kwalitee Is Job One Let me check my notes. http://www.sluggy.com