Re: [perl #24119] CPAN.pm error in Win32: uses rename() not File::Copy::move

2005-07-12 Thread Steve Hay
Michael G Schwern via RT wrote: >The attached patch changes all the unsafe uses of rename() to >File::Copy::move(). These are the ones which move a path to a different >directory. All the rest work within the same dir and should be safe. > Thanks. Applied as change 25125.

[perl #24119] CPAN.pm error in Win32: uses rename() not File::Copy::move

2005-07-11 Thread Michael G Schwern via RT
The attached patch changes all the unsafe uses of rename() to File::Copy::move(). These are the ones which move a path to a different directory. All the rest work within the same dir and should be safe. CPAN.pm.patch Description: Binary data

[perl #24119] CPAN.pm error in Win32: uses rename() not File::Copy::move

2005-07-11 Thread Michael G Schwern via RT
> [EMAIL PROTECTED] - Sun Oct 05 08:06:14 2003]: > > CPAN.pm (invoked as cpan in the command shell) reports a permission > problem trying to move a directory. The trouble is that CPAN.pm is using > the rename() function, which in Win32 can change a file's name but not > move it from one directo

Re: [PATCH] Re: [perl #24119] CPAN.pm error in Win32: uses rename() not File::Copy::move

2005-04-08 Thread Steve Hay
Steven Schubiger wrote: >Attached is the improved patch. > > Thanks. Applied as 24209 (with the argument names changed to match perlfunc.pod). - Steve >Steven > > >This email has been scanned for viruses and content by the Radan Computational

Re: [PATCH] Re: [perl #24119] CPAN.pm error in Win32: uses rename() not File::Copy::move

2005-04-08 Thread Steven Schubiger
Attached is the improved patch. Steven--- perlport.pod.orig Fri Nov 12 22:13:04 2004 +++ perlport.podThu Apr 7 22:30:55 2005 @@ -1836,6 +1836,10 @@ Not implemented. (Win32, VMS, S) +=item rename SOURCE,DESTINATION + +Can't move directories between directories on different logical v

RE: [PATCH] Re: [perl #24119] CPAN.pm error in Win32: uses rename() not File::Copy::move

2005-04-04 Thread Jan Dubois
On Mon, 04 Apr 2005, Steve Hay wrote: > Jan Dubois wrote: >> This is actually not exactly true. rename() can move files to >> different directories on Win32 as long as source and destination are >> on the same filesystem. >> > On my WinXP box, rename() can move files to different directories, > inc

Re: [PATCH] Re: [perl #24119] CPAN.pm error in Win32: uses rename() not File::Copy::move

2005-04-04 Thread demerphq
On Apr 4, 2005 6:28 PM, Steve Hay <[EMAIL PROTECTED]> wrote: > Ton Hospel wrote: > > >In article <[EMAIL PROTECTED]>, > > Steven Schubiger <[EMAIL PROTECTED]> writes: > > > > > >>On 07 Oct 2003 00:00:13 +0200, Slaven Rezic <[EMAIL PROTECTED]> wrote: > >> > >>:> CPAN.pm (invoked as cpan in t

Re: [PATCH] Re: [perl #24119] CPAN.pm error in Win32: uses rename() not File::Copy::move

2005-04-04 Thread Steve Hay
Ton Hospel wrote: >In article <[EMAIL PROTECTED]>, > Steven Schubiger <[EMAIL PROTECTED]> writes: > > >>On 07 Oct 2003 00:00:13 +0200, Slaven Rezic <[EMAIL PROTECTED]> wrote: >> >>:> CPAN.pm (invoked as cpan in the command shell) reports a permission >>:> problem trying to move a directo

Re: [PATCH] Re: [perl #24119] CPAN.pm error in Win32: uses rename() not File::Copy::move

2005-04-04 Thread Steve Hay
Jan Dubois wrote: >On Sat, 02 Apr 2005, Steven Schubiger wrote: > > >>On 07 Oct 2003 00:00:13 +0200, Slaven Rezic <[EMAIL PROTECTED]> wrote: >> >>:> CPAN.pm (invoked as cpan in the command shell) reports a permission >>:> problem trying to move a directory. The trouble is that CPAN.pm is using

Re: [PATCH] Re: [perl #24119] CPAN.pm error in Win32: uses rename() not File::Copy::move

2005-04-03 Thread Ton Hospel
In article <[EMAIL PROTECTED]>, Steven Schubiger <[EMAIL PROTECTED]> writes: > On 07 Oct 2003 00:00:13 +0200, Slaven Rezic <[EMAIL PROTECTED]> wrote: > >:> CPAN.pm (invoked as cpan in the command shell) reports a permission >:> problem trying to move a directory. The trouble is that CPAN

RE: [PATCH] Re: [perl #24119] CPAN.pm error in Win32: uses rename() not File::Copy::move

2005-04-02 Thread Jan Dubois
On Sat, 02 Apr 2005, Steven Schubiger wrote: > On 07 Oct 2003 00:00:13 +0200, Slaven Rezic <[EMAIL PROTECTED]> wrote: > > :> CPAN.pm (invoked as cpan in the command shell) reports a permission > :> problem trying to move a directory. The trouble is that CPAN.pm is using > :> the rename() function

[PATCH] Re: [perl #24119] CPAN.pm error in Win32: uses rename() not File::Copy::move

2005-04-02 Thread Steven Schubiger
On 07 Oct 2003 00:00:13 +0200, Slaven Rezic <[EMAIL PROTECTED]> wrote: :> CPAN.pm (invoked as cpan in the command shell) reports a permission :> problem trying to move a directory. The trouble is that CPAN.pm is using :> the rename() function, which in Win32 can change a file's name but not :> m