Re: Last call for MM issues prior to 6.26

2005-03-21 Thread Michael G Schwern
On Mon, Mar 21, 2005 at 09:58:39AM -0800, Yitzchak Scott-Thoennes wrote: > Another alternative would be to rename the thing > no_compiler, returning undef or an explanation. But I'm not going to > pursue these alternatives unless someone likes them better. Hey, I like that.

Re: Last call for MM issues prior to 6.26

2005-03-21 Thread Ken Williams
On Mar 21, 2005, at 11:58 AM, Yitzchak Scott-Thoennes wrote: An alternative would be to have have_compiler return ($have_compiler, $errmsg) if wantarray. That makes the code in the caller more clunky though (IMO). Another alternative would be to rename the thing no_compiler, returning undef or an

Re: Last call for MM issues prior to 6.26

2005-03-21 Thread Ken Williams
On Mar 21, 2005, at 12:02 PM, Yitzchak Scott-Thoennes wrote: I'm a client too. I don't use CPAN or CPANPLUS usually to build things, I manually check for dependencies. I dislike it when a module that has dependencies (even just for tests) doesn't mention them in Makefile, META.yml, or a README o

Re: Last call for MM issues prior to 6.26

2005-03-21 Thread Yitzchak Scott-Thoennes
On Mon, Mar 21, 2005 at 09:55:37AM -0600, Ken Williams wrote: > > On Mar 20, 2005, at 2:08 PM, Yitzchak Scott-Thoennes wrote: > > >On Sun, Mar 20, 2005 at 12:30:01AM -0800, Michael G Schwern wrote: > >>On Sat, Mar 19, 2005 at 10:51:39PM -0800, Yitzchak Scott-Thoennes > >>wrote: > >>>I was a litt

Re: Last call for MM issues prior to 6.26

2005-03-21 Thread Yitzchak Scott-Thoennes
On Mon, Mar 21, 2005 at 09:57:26AM -0600, Ken Williams wrote: > > On Mar 20, 2005, at 4:09 PM, Yitzchak Scott-Thoennes wrote: > >I was thinking along the lines of: > > > > > >if (have_compiler($errmsg)) { > >plan tests => 1; > >} else { > >plan skip_all => $errmsg; > >} > > > > > > > >sub

Re: Last call for MM issues prior to 6.26

2005-03-21 Thread Ken Williams
On Mar 20, 2005, at 2:08 PM, Yitzchak Scott-Thoennes wrote: On Sun, Mar 20, 2005 at 12:30:01AM -0800, Michael G Schwern wrote: On Sat, Mar 19, 2005 at 10:51:39PM -0800, Yitzchak Scott-Thoennes wrote: I was a little surprised to see t/xs reporting "No compiler found to test XS builds", till I saw t

Re: Last call for MM issues prior to 6.26

2005-03-21 Thread Ken Williams
On Mar 20, 2005, at 4:09 PM, Yitzchak Scott-Thoennes wrote: I was thinking along the lines of: if (have_compiler($errmsg)) { plan tests => 1; } else { plan skip_all => $errmsg; } sub have_compiler { my $errmsg = ""; ... $_[0] = $errmsg if @_; return $have_compiler; } It would p

Re: Last call for MM issues prior to 6.26

2005-03-21 Thread Nicholas Clark
On Fri, Mar 18, 2005 at 04:20:21PM -0800, Michael G Schwern wrote: > Nothing critical has been been reported (that hasn't been fixed) in 6.25_11 > so 6.25_12 has just been released. Unless I hear otherwise by Tuesday this > will become ExtUtils::MakeMaker 6.26. I put the snapshot inside blead on

Re: Last call for MM issues prior to 6.26

2005-03-20 Thread Michael G Schwern
On Sun, Mar 20, 2005 at 02:09:22PM -0800, Yitzchak Scott-Thoennes wrote: > I was thinking along the lines of: > > if (have_compiler($errmsg)) { > plan tests => 1; > } else { > plan skip_all => $errmsg; > } Patches welcome.

Re: Last call for MM issues prior to 6.26

2005-03-20 Thread Yitzchak Scott-Thoennes
On Sun, Mar 20, 2005 at 01:48:35PM -0800, Michael G Schwern wrote: > On Sun, Mar 20, 2005 at 12:06:51PM -0800, Yitzchak Scott-Thoennes wrote: > > It's really a gray area. cygwin aims at providing a linux-like > > environment, and when one cygwin program starts another, the args are > > passed in a

Re: Last call for MM issues prior to 6.26

2005-03-20 Thread Yitzchak Scott-Thoennes
On Sun, Mar 20, 2005 at 01:47:38PM -0800, Michael G Schwern wrote: > On Sun, Mar 20, 2005 at 12:08:54PM -0800, Yitzchak Scott-Thoennes wrote: > > > There is no equivalent in MakeMaker. > > > > And you can't hand-alter the META.yml? > > Yes but then I would have to turn off the META.yml auto-gen

Re: Last call for MM issues prior to 6.26

2005-03-20 Thread Michael G Schwern
On Sun, Mar 20, 2005 at 12:06:51PM -0800, Yitzchak Scott-Thoennes wrote: > It's really a gray area. cygwin aims at providing a linux-like > environment, and when one cygwin program starts another, the args are > passed in an actual array; it's just when a non-cygwin program starts > a cygwin progr

Re: Last call for MM issues prior to 6.26

2005-03-20 Thread Michael G Schwern
On Sun, Mar 20, 2005 at 12:08:54PM -0800, Yitzchak Scott-Thoennes wrote: > > There is no equivalent in MakeMaker. > > And you can't hand-alter the META.yml? Yes but then I would have to turn off the META.yml auto-generation for good. Also ExtUtils::CBuilder is an optional build requirement. It

Re: Last call for MM issues prior to 6.26

2005-03-20 Thread Yitzchak Scott-Thoennes
On Sun, Mar 20, 2005 at 12:30:01AM -0800, Michael G Schwern wrote: > On Sat, Mar 19, 2005 at 10:51:39PM -0800, Yitzchak Scott-Thoennes wrote: > > I was a little surprised to see t/xs reporting "No compiler found to > > test XS builds", till I saw that it is checking for Extutils::CBuilder. > > Coul

Re: Last call for MM issues prior to 6.26

2005-03-20 Thread Yitzchak Scott-Thoennes
On Sun, Mar 20, 2005 at 12:24:54AM -0800, Michael G Schwern wrote: > On Sat, Mar 19, 2005 at 10:20:59PM -0800, Yitzchak Scott-Thoennes wrote: > > I encountered a problem with quoting when running a cygwin gcc (in > > this case, in "-mno-cygwin" MinGW mode) from a non-cygwin make that > > the follow

Re: Last call for MM issues prior to 6.26

2005-03-20 Thread Michael G Schwern
On Sat, Mar 19, 2005 at 10:51:39PM -0800, Yitzchak Scott-Thoennes wrote: > I was a little surprised to see t/xs reporting "No compiler found to > test XS builds", till I saw that it is checking for Extutils::CBuilder. > Could that be added to build_recommends (or whatever the appropriate > tag is)

Re: Last call for MM issues prior to 6.26

2005-03-20 Thread Michael G Schwern
On Sat, Mar 19, 2005 at 10:20:59PM -0800, Yitzchak Scott-Thoennes wrote: > I encountered a problem with quoting when running a cygwin gcc (in > this case, in "-mno-cygwin" MinGW mode) from a non-cygwin make that > the following patch would fix, but I've been hesitant to send it to > you because I d

Re: Last call for MM issues prior to 6.26

2005-03-19 Thread Yitzchak Scott-Thoennes
On Fri, Mar 18, 2005 at 04:20:21PM -0800, Michael G Schwern wrote: > Nothing critical has been been reported (that hasn't been fixed) in 6.25_11 > so 6.25_12 has just been released. Unless I hear otherwise by Tuesday this > will become ExtUtils::MakeMaker 6.26. > > Why make such a fuss? Because

Re: Last call for MM issues prior to 6.26

2005-03-19 Thread Yitzchak Scott-Thoennes
On Fri, Mar 18, 2005 at 04:20:21PM -0800, Michael G Schwern wrote: > Nothing critical has been been reported (that hasn't been fixed) in 6.25_11 > so 6.25_12 has just been released. Unless I hear otherwise by Tuesday this > will become ExtUtils::MakeMaker 6.26. > > Why make such a fuss? Because

Last call for MM issues prior to 6.26

2005-03-18 Thread Michael G Schwern
Nothing critical has been been reported (that hasn't been fixed) in 6.25_11 so 6.25_12 has just been released. Unless I hear otherwise by Tuesday this will become ExtUtils::MakeMaker 6.26. Why make such a fuss? Because I'll be offering 6.26 as being stable enough for 5.8.x, the first new release