[perl #48074] [PATCH] fix for pcre test if libpcre installed in non-standard location

2007-12-30 Thread James Keenan via RT
The patch has been in head for more than a week now, with no complaints. So I'm resolving the ticket. kid51

Re: [PATCH] fix for pcre test if libpcre installed in non-standard location

2007-12-20 Thread Mark J. Reed
That output suggests that you dont have libpcre installed, which makes it not much of a test for the patch. :) On 12/19/07, James Keenan via RT [EMAIL PROTECTED] wrote: On Mon Dec 03 20:04:08 2007, [EMAIL PROTECTED] wrote: Uploading updated version of patch based on discussion with chromatic

Re: [PATCH] fix for pcre test if libpcre installed in non-standard location

2007-12-20 Thread Devin Heitmueller
Mark is correct. If the pcre-config program cannot be found, then this is the condition you should expect. Note that libpcre does not come with OSX, so this is not unusual (I have it installed via Fink). Devin On Dec 20, 2007 8:48 AM, Mark J. Reed [EMAIL PROTECTED] wrote: That output suggests

[perl #48074] [PATCH] fix for pcre test if libpcre installed in non-standard location

2007-12-20 Thread James Keenan via RT
Patch applied to trunk in r24118. Devin Heitmueller++ for his first contribution to Parrot! kid51

[perl #48074] [PATCH] fix for pcre test if libpcre installed in non-standard location

2007-12-19 Thread James Keenan via RT
On Mon Dec 03 20:04:08 2007, [EMAIL PROTECTED] wrote: Uploading updated version of patch based on discussion with chromatic on perl6-internals mailing list. I spoke with Devin at the Perl 20th birthday celebration in New York last night and he asked me to nudge this patch forward. Can we get

[perl #48074] [PATCH] fix for pcre test if libpcre installed in non-standard location

2007-12-19 Thread James Keenan via RT
On Mon Dec 03 20:04:08 2007, [EMAIL PROTECTED] wrote: Uploading updated version of patch based on discussion with chromatic on perl6-internals mailing list. Devin: This is the result I got when I applied the 2nd version of your patch on Darwin and then ran the patched test file: [parrot] 516

[perl #48074] [PATCH] fix for pcre test if libpcre installed in non-standard location

2007-12-03 Thread Devin Heitmueller
# New Ticket Created by Devin Heitmueller # Please include the string: [perl #48074] # in the subject line of all future correspondence about this issue. # URL: http://rt.perl.org/rt3/Ticket/Display.html?id=48074 The attached patch will address a parrot test failure in the PCRE module

[PATCH] fix for pcre test if libpcre installed in non-standard location

2007-12-02 Thread Devin Heitmueller
The attached patch will address a parrot test failure in the PCRE module (t/library/pcre.t) in the case where the libpcre library is installed in a nonstandard location. In my case, it occurs on OS X that Fink installed libpcre into /sw/lib, and so the test believes that PCRE is installed because

Re: [PATCH] fix for pcre test if libpcre installed in non-standard location

2007-12-02 Thread chromatic
On Sunday 02 December 2007 21:04:28 Devin Heitmueller wrote: The attached patch will address a parrot test failure in the PCRE module (t/library/pcre.t) in the case where the libpcre library is installed in a nonstandard location. In my case, it occurs on OS X that Fink installed libpcre

Re: [PATCH] fix for pcre test if libpcre installed in non-standard location

2007-12-02 Thread Devin Heitmueller
In order to insert the $pcre_libpath into the content of the PIR, I had to change the interpolation mode in pir_output_is(). This therefore required me to escape the backslashes in the heredoc. If there's a more preferred approach to this sort of problem, let me know and I will happy resubmit

Re: [PATCH] fix for pcre test if libpcre installed in non-standard location

2007-12-02 Thread chromatic
On Sunday 02 December 2007 21:21:49 Devin Heitmueller wrote: In order to insert the $pcre_libpath into the content of the PIR, I had to change the interpolation mode in pir_output_is(). This therefore required me to escape the backslashes in the heredoc. Oh. I missed that, but it makes