Have heard no complaints; resolving ticket.
I had some off-list conversations with ptc about a month ago about these
issues. Running the step with --verbose-step indicated that attributes
that the compiler does not recognize do not get added to the 'ccflags'
attribute. Cf. patch applied to trunk:
Either config/auto/attributes.pm is now DWIMming or I don't understand
it correctly. Please help me determine which.
Consider the first of two files attached (neither of which is yet in
trunk): t/configure/114-auto_attributes-02.t. It's set up like many of
the other t/configure/*.t tests, no
Patch applied in r22436 for $/ problem. Am still considering other
refinements per chromatic's suggestion.
While examining this file for the purpose of writing tests, I noticed
that it uses Perl's special variable $/ in 6 instances where a newline
would suffice.
[parrot] 504 $ grep -n '$/' config/auto/attributes.pm
54:print $/ if $verbose;
67:$verbose and print trying attribute '$attr'$/;
83:
No reason I can see, other than golf.
On Oct 22, 2007, at 9:01 PM, James Keenan via RT wrote:
While examining this file for the purpose of writing tests, I noticed
that it uses Perl's special variable $/ in 6 instances where a newline
would suffice.
[parrot] 504 $ grep -n '$/'
On Monday 22 October 2007 18:01:27 James Keenan via RT wrote:
While examining this file for the purpose of writing tests, I noticed
that it uses Perl's special variable $/ in 6 instances where a newline
would suffice.
[parrot] 504 $ grep -n '$/' config/auto/attributes.pm
54:print $/ if
On Mon Oct 22 18:16:51 2007, [EMAIL PROTECTED] wrote:
i.e., Why we do we need this here when \n suffices everywhere else
in
the Parrot distribution?
I can't think of a reason. While you're at it, how about getting rid
of the
use of 'and' for flow control here by turning them into print
On 23/10/2007, James Keenan via RT [EMAIL PROTECTED] wrote:
While examining this file for the purpose of writing tests, I noticed
that it uses Perl's special variable $/ in 6 instances where a newline
would suffice.
[parrot] 504 $ grep -n '$/' config/auto/attributes.pm
54:print $/ if
On 10/22/07, James Keenan via RT [EMAIL PROTECTED] wrote:
On Mon Oct 22 18:16:51 2007, [EMAIL PROTECTED] wrote:
i.e., Why we do we need this here when \n suffices everywhere else
in
the Parrot distribution?
I can't think of a reason. While you're at it, how about getting rid
of
File holding framework for writing tests for this configuration step was
committed to trunk Oct 21 2007 in r22362. Tests do not yet provide high
coverage due to obstacles in testing runstep(). You are encouraged to
poke around and add tests.
11 matches
Mail list logo
