[perl #44753] [PATCH] find current revision for git

2007-08-18 Thread James Keenan via RT
Since the original submission to parrotbug wasn't CC-ed to the list, I am attaching it here. diff --git a/lib/Parrot/Revision.pm b/lib/Parrot/Revision.pm index 53ff1ef..c5b85fb 100644 --- a/lib/Parrot/Revision.pm +++ b/lib/Parrot/Revision.pm @@ -36,6 +36,9 @@ sub __get_revision { ($rev

[perl #44753] [PATCH] find current revision for git

2007-08-18 Thread James Keenan via RT
1. I added a reference to RT 42360 which requests unit tests for the SVK portion of Parrot::Revision's code. 2. Would it be possible to add tests for the git-related code in your patch to the following 4 test files: t//configure/017-revision_no_DEVELOPING.t t//configure/018-revision.t t//postco

[perl #44753] [PATCH] find current revision for git

2007-08-19 Thread James Keenan via RT
Patch applied to trunk in r20720. Thanks, David.

Re: [perl #44753] [PATCH] find current revision for git

2007-08-19 Thread David Romano
James Keenan via RT wrote on Sat, Aug 18, 2007 at 06:31:27PM PDT: > 1. I added a reference to RT 42360 which requests unit tests for the > SVK portion of Parrot::Revision's code. > > 2. Would it be possible to add tests for the git-related code in your > patch to the following 4 test files: > >