[perl #45695] [PATCH] Remove seemingly unnecessary Parrot_cont-from_ctx

2008-03-16 Thread James Keenan via RT
Contributors to this thread: Can you give us an update on the issues that were being discussed? (There's been no activity in thread for 6 months.) Thank you very much. kid51

Re: [perl #45695] [PATCH] Remove seemingly unnecessary Parrot_cont-from_ctx

2007-09-25 Thread Bram Geron
Mehmet Yavuz Selim Soyturk wrote: -if (cc-from_ctx) -Parrot_free_context(interp, cc-from_ctx, 0); -Parrot_free_context(INTERP, from_ctx, 1); I don't know much about this context stuff, so maybe I don't see something, but how are those contexts freed

Re: [perl #45695] [PATCH] Remove seemingly unnecessary Parrot_cont-from_ctx

2007-09-25 Thread chromatic
On Tuesday 25 September 2007 15:05:21 Bram Geron wrote: Reasoning from this model, I can't see what from_ctx is for. After solving one exception, there is no place that uses the value of from_ctx. So if a piece of code uses that context, it's stored at another place and that place should

[perl #45695] [PATCH] Remove seemingly unnecessary Parrot_cont-from_ctx

2007-09-24 Thread via RT
# New Ticket Created by Bram Geron # Please include the string: [perl #45695] # in the subject line of all future correspondence about this issue. # URL: http://rt.perl.org/rt3/Ticket/Display.html?id=45695 Parrot_cont (the internal structure storing info about (Ret)Continuations) has two

Re: [perl #45695] [PATCH] Remove seemingly unnecessary Parrot_cont-from_ctx

2007-09-24 Thread Mehmet Yavuz Selim Soyturk
-if (cc-from_ctx) -Parrot_free_context(interp, cc-from_ctx, 0); -Parrot_free_context(INTERP, from_ctx, 1); I don't know much about this context stuff, so maybe I don't see something, but how are those contexts freed after your patch?

Re: [perl #45695] [PATCH] Remove seemingly unnecessary Parrot_cont-from_ctx

2007-09-24 Thread Leopold Toetsch
Am Sonntag, 23. September 2007 20:19 schrieb Bram Geron: To test if 'from_ctx' is redundant, I tried removing the field and all accesses to it, and no extra tests failed (see patch). Did you run a memory leak test? The from_ctx is refcounted for some reason. leo