Re: [perl #51652] [PATCH] Possible alignment issues with new STRING structures

2008-07-08 Thread Andy Dougherty
On Mon, 7 Jul 2008, Andrew Whitworth via RT wrote: > On Thu Mar 13 18:06:21 2008, doughera wrote: > > I don't know if those calculations are still correct, now that strings > > are not "bufferlike". > > Most of the memory management code uses a cast to (Buffer *) or (PObj *) > to test a generic o

Re: [perl #51652] [PATCH] Possible alignment issues with new STRING structures

2008-07-07 Thread Andy Dougherty
On Mon, 7 Jul 2008, Andrew Whitworth via RT wrote: > On Thu Mar 13 18:06:21 2008, doughera wrote: > > I don't know if those calculations are still correct, now that strings > > are not "bufferlike". > > Most of the memory management code uses a cast to (Buffer *) or (PObj *) > to test a generic o

Re: [perl #51652] [PATCH] Possible alignment issues with new STRING structures

2008-03-13 Thread Andy Dougherty
On Thu, 13 Mar 2008, chromatic via RT wrote: > On Thursday 13 March 2008 09:14:07 Andy Dougherty wrote: > > > On Thu, 13 Mar 2008, Nicholas Clark via RT wrote: > > > > Specifically, I am suspecting that if > > > > > > offsetof(struct parrot_string_t, bufused) == sizeof(Buffer) > > > > > > ma

Re: [perl #51652] [PATCH] Possible alignment issues with new STRING structures

2008-03-13 Thread Leopold Toetsch
Am Donnerstag, 13. März 2008 23:01 schrieb chromatic: > It looks like the UnionVal is two pointers long, so if we rearranged things > such that flags comes first, would the Buffer structure get padded so that > anything after that in memory starts at the appropriate alignment for a > pointer? Look

Re: [perl #51652] [PATCH] Possible alignment issues with new STRING structures

2008-03-13 Thread chromatic
On Thursday 13 March 2008 09:14:07 Andy Dougherty wrote: > On Thu, 13 Mar 2008, Nicholas Clark via RT wrote: > > Specifically, I am suspecting that if > > > > offsetof(struct parrot_string_t, bufused) == sizeof(Buffer) > > > > matters, then something is either looking at or copying (sub)struc

Re: [perl #51652] [PATCH] Possible alignment issues with new STRING structures

2008-03-13 Thread Andy Dougherty
On Thu, 13 Mar 2008, Nicholas Clark via RT wrote: > Specifically, I am suspecting that if > > offsetof(struct parrot_string_t, bufused) == sizeof(Buffer) > > matters, then something is either looking at or copying (sub)structures than > happen to have padding, and in turn that padding happen

Re: [perl #51652] [PATCH] Possible alignment issues with new STRING structures

2008-03-13 Thread Nicholas Clark
On Wed, Mar 12, 2008 at 07:19:06AM -0700, Andy Dougherty wrote: > I haven't been able to track down the problem. I vaguely suspect it's > an alignment/structure padding issue. Specifically, in the old > version, > offsetof(struct parrot_string_t, bufused) == sizeof(Buffer), > but that wasn't

[perl #51652] [PATCH] Possible alignment issues with new STRING structures

2008-03-12 Thread via RT
# New Ticket Created by Andy Dougherty # Please include the string: [perl #51652] # in the subject line of all future correspondence about this issue. # http://rt.perl.org/rt3/Ticket/Display.html?id=51652 > There might be a possible alignment issue lurking in the new streamlined PMC and STRI