Re: [perl #60168] [PATCH] Refactor Junction.

2008-10-28 Thread Moritz Lenz
Patrick R. Michaud wrote: > On Mon, Oct 27, 2008 at 03:47:50AM -0700, Vasily Chekalkin wrote: >> I've (slightly) refactor Junction.pir. >> >> 1. Get rid of "junction_comparision_helper". Use "infix_junction_helper" >> instead. >> 2. In "infix" and "unary" junction helpers store original value in

Re: [perl #60168] [PATCH] Refactor Junction.

2008-10-28 Thread Jonathan Worthington
Patrick R. Michaud wrote: Note that all of this effectively disappears when we have the dispatcher handling Junctions properly -- i.e., the specialized operator functions defined in Junction really should not exist. Yup, and I don't plan to spend any more time on those functions inside Juncti

Re: [perl #60168] [PATCH] Refactor Junction.

2008-10-28 Thread Patrick R. Michaud
On Tue, Oct 28, 2008 at 07:10:15PM +1100, Vasily Chekalkin wrote: >> Note that all of this effectively disappears when we have >> the dispatcher handling Junctions properly -- i.e., the >> specialized operator functions defined in Junction really >> should not exist. > > Indeed. But current state o

Re: [perl #60168] [PATCH] Refactor Junction.

2008-10-28 Thread Vasily Chekalkin
Patrick R. Michaud via RT wrote: On Mon, Oct 27, 2008 at 03:47:50AM -0700, Vasily Chekalkin wrote: I've (slightly) refactor Junction.pir. 1. Get rid of "junction_comparision_helper". Use "infix_junction_helper" instead. 2. In "infix" and "unary" junction helpers store original value in Result

Re: [perl #60168] [PATCH] Refactor Junction.

2008-10-27 Thread Patrick R. Michaud
On Mon, Oct 27, 2008 at 03:47:50AM -0700, Vasily Chekalkin wrote: > I've (slightly) refactor Junction.pir. > > 1. Get rid of "junction_comparision_helper". Use "infix_junction_helper" > instead. > 2. In "infix" and "unary" junction helpers store original value in > ResultHash to avoid stringific

[perl #60168] [PATCH] Refactor Junction.

2008-10-27 Thread via RT
# New Ticket Created by Vasily Chekalkin # Please include the string: [perl #60168] # in the subject line of all future correspondence about this issue. # http://rt.perl.org/rt3/Ticket/Display.html?id=60168 > Hello. I've (slightly) refactor Junction.pir. 1. Get rid of "junction_comparision_