[perl #67622] [PATCH] Make Test.pm consider Null PMC access an invalid death in dies_ok

2009-07-16 Thread Kyle Hasselbacher
# New Ticket Created by Kyle Hasselbacher # Please include the string: [perl #67622] # in the subject line of all future correspondence about this issue. # URL: http://rt.perl.org/rt3/Ticket/Display.html?id=67622 Sometimes something dies, as it should, but with the wrong error. The best

Re: [perl #67622] [PATCH] Make Test.pm consider Null PMC access an invalid death in dies_ok

2009-07-16 Thread Moritz Lenz
Kyle Hasselbacher (via RT) wrote: Sometimes something dies, as it should, but with the wrong error. The best way to test this is to specify the correct error, but we don't always have the correct error. This patch makes dies_ok reject a particular Rakudo-specific error that is always

Re: [perl #67622] [PATCH] Make Test.pm consider Null PMC access an invalid death in dies_ok

2009-07-16 Thread Kyle Hasselbacher
On Thu, Jul 16, 2009 at 4:30 PM, Moritz Lenz via RTperl6-bugs-follo...@perl.org wrote: I like the idea very much, but the current implementation is a bit confusing. The test code dies, but dies_ok still fails. Maybe adding a diag($explanation) might improve that. (Maybe I get around to