Re: Modifying PDD15 classes

2007-11-20 Thread Allison Randal
Jonathan Worthington wrote: While that is fine, I noticed that add_method and add_vtable_override are missing this has the class been instantiated test. Putting it in, however, makes some tests fail. Am I right in thinking the tests are wrong and need to be fixed to clone the (already

Modifying PDD15 classes

2007-11-17 Thread Jonathan Worthington
Hi, As far as I remember, and can see in PDD15, if you want to modify a class after it has been instantiated you should clone it and do the modifications to the clone. Therefore, #46097 and #46093 are resolvable by removing the comment that dates back to before the decision and changing the