Re: patch to support nums, strings and pmcs as attributes

2004-01-12 Thread Nicholas Clark
On Sun, Jan 11, 2004 at 07:33:12PM +0100, Stéphane Payrard wrote: > Also the following patch exercises all the variations including > the susmentioned access thru a key pmc that may contain either a > string or an int. Thanks, applied Nicholas Clark

Re: patch to support nums, strings and pmcs as attributes

2004-01-12 Thread Leopold Toetsch
Dan Sugalski <[EMAIL PROTECTED]> wrote: > At 10:22 PM +0100 1/10/04, Stéphane Payrard wrote: >>--- classes/parrotobject.pmc.orig 2003-12-06 01:00:29.0 +0100 >>+++ classes/parrotobject.pmc 2004-01-10 21:09:08.0 +0100 > Keen. And, while worth applying, I'm not sure it > should g

Re: patch to support nums, strings and pmcs as attributes

2004-01-12 Thread Dan Sugalski
At 10:22 PM +0100 1/10/04, Stéphane Payrard wrote: --- classes/parrotobject.pmc.orig 2003-12-06 01:00:29.0 +0100 +++ classes/parrotobject.pmc2004-01-10 21:09:08.0 +0100 Keen. And, while worth applying, I'm not sure it should go to parrotobject. (Or, rather, I think it ou

Re: patch to support nums, strings and pmcs as attributes

2004-01-11 Thread Stéphane Payrard
On Sun, Jan 11, 2004 at 12:33:16PM +0100, Leopold Toetsch wrote: > Stéphane Payrard <[EMAIL PROTECTED]> wrote: > > Thanks, applied - plus ... > > > INTVAL get_integer_keyed (PMC* attr) { > > - return SELF.get_integer_keyed_str(key_string(interpreter, attr)); > > +int flag = PObj_ge

Re: patch to support nums, strings and pmcs as attributes

2004-01-11 Thread Leopold Toetsch
Stéphane Payrard <[EMAIL PROTECTED]> wrote: Thanks, applied - plus ... > INTVAL get_integer_keyed (PMC* attr) { > - return SELF.get_integer_keyed_str(key_string(interpreter, attr)); > +int flag = PObj_get_FLAGS(attr) & KEY_type_FLAGS; ... a comment, why we might need that. leo

patch to support nums, strings and pmcs as attributes

2004-01-10 Thread Stéphane Payrard
--- classes/parrotobject.pmc.orig 2003-12-06 01:00:29.0 +0100 +++ classes/parrotobject.pmc2004-01-10 21:09:08.0 +0100 @@ -87,7 +87,12 @@ } INTVAL get_integer_keyed (PMC* attr) { - return SELF.get_integer_keyed_str(key_string(interpreter, attr)); +