Re: Warnings Cleanup

2002-03-27 Thread Josh Wilmes
I've applied portions of this patch. I omitted the parts which use the "byte" type, which isn't going to work on all platforms. --Josh At 1:46 on 03/28/2002 EST, Michel J Lambert <[EMAIL PROTECTED]> wrote: > Attached patch fixes many of the warnings you see on MSVC level 4. The > ones listed

Re: "deep" tests for stacks.t

2002-03-27 Thread Josh Wilmes
Mike pointed out that I was missing "end" opcodes in there, so I added them and went ahead and committed this code to CVS. Currently test #7 is failing, but I think it's a legitimate bug- if not, I apologize for breaking the tinderbox ;) --Josh At 1:15 on 03/28/2002 EST, Josh Wilmes <[EMAIL

Warnings Cleanup

2002-03-27 Thread Michel J Lambert
Attached patch fixes many of the warnings you see on MSVC level 4. The ones listed below, this patch does *not* handle. core.ops and rx.ops have some warnings about the use of MAKE_KEY, and the non-use of the variables returned by MAKE_KEY. I believe Steve Fink's patch fixes these. io_win32.c

"deep" tests for stacks.t

2002-03-27 Thread Josh Wilmes
I added some tests which push larger numbers of stack frames- this improves our coverage in register.c. However, one of the tests is failing for me. Is this something I did wrong, or did I find a bug? I'm getting weird output for the pushp and popp (deep) test. --Josh Here's the patch: In

Re: Computed-goto Patch

2002-03-27 Thread Michel J Lambert
Attached are my revised files. pbc2c.pl uses Parrot::OpTrans::Compiled, and this patch uses Parrot::OpTrans::CGoto. It also fixed the issues with the last patch: - removed inadvertant keyed commenting - fixed #include name - fixed pbc2c.pl - should have unix line endings Please let me know if th

[Applied] t/pmc/.cvsignore

2002-03-27 Thread Josh Wilmes
Thanks, done. At 2:59 on 03/27/2002 EST, Michel J Lambert <[EMAIL PROTECTED]> wrote: > The introduction "make quicktest" made this missing .cvsignore more > apparent. > > Mike Lambert >

Re: Computed-goto Patch

2002-03-27 Thread Steve Fink
On Wed, Mar 27, 2002 at 02:46:21PM -0500, Michel J Lambert wrote: > My methodology in creating this patch was to first apply Daniel's patch, > and then get it working. His patch had significant changes to an older > version of pbc2c.pl, which I tried to apply to the newest version. I then > procee

Re: Computed-goto Patch

2002-03-27 Thread Michel J Lambert
> The patch is slightly broken, core_cg_ops.h in interpreter.c versus > core_ops_cg.h everywhere else. I tried to do a global change to make it use core_ops_cg.h, following prederef's example. I must have missed this one. (Still runs, just gives a warning.) > It does take a while to build the co

Re: [PATCH] keys

2002-03-27 Thread Steve Fink
On Wed, Mar 27, 2002 at 11:15:22AM -0800, Steve Fink wrote: > I'll send a followup patch that updates the .ops files (mainly rx.ops) > to define and use the working MAKE_KEY. And here it is. Index: core.ops === RCS file: /home/perlc

[PATCH] keys

2002-03-27 Thread Steve Fink
I'm probably misunderstanding something, but I'm using keys for groups in regular expressions (the uses are internal and so require no assembler support), and I was getting a lot of seg faults. After taking a look, I don't understand the reason for the extra level of indirection to KEY_PAIRs. A KE

Re: Computed-goto Patch

2002-03-27 Thread Jason Gloudon
On Wed, Mar 27, 2002 at 02:55:59AM -0500, Michel J Lambert wrote: > Attached is a patch to implement computed-goto on gcc, taken from the > original post by Daniel Grunblatt: > http:[EMAIL PROTECTED]/msg06255.html The patch is slightly broken, core_cg_ops.h in interpreter.c versus core_ops_cg.h e

Re: Computed-goto Patch

2002-03-27 Thread Simon Cozens
Melvin Smith: > Simon is on vacation and may or may > not be doing anything with assembler, keyed aggregate, etc. I'm not on vacation yet. :) I'm not doing any more work on the assembler, but I'm leaving it to Jeff to decide whether or not to apply it. I think packfile.c will need updating when/i

Re: [PATCH] Stack bugfix

2002-03-27 Thread Melvin Smith
At 09:47 AM 3/27/2002 +0200, Peter Gibbs wrote: >- Original Message - >From: "Melvin Smith" <[EMAIL PROTECTED]> > > ../parrot reverse.pbc < string.c > > > > > > > > recurse depth 0 > > Segmentation fault (core dumped) > >This seems to caused by a nice timing problem - the string header ha

Re: Computed-goto Patch

2002-03-27 Thread Melvin Smith
At 03:16 AM 3/27/2002 -0500, Michel J Lambert wrote: >Doh, sorry about that. > >If it makes you feel any better (or worse), I was in the midst of writing >up the email for fixing the pushp bug you mentioned, when up pops '[PATCH] >Stack fix' in my email inbox, turning my local bug fix into a nice