[perl #40523] [TODO] adjust string_append function and usage

2006-10-26 Thread [EMAIL PROTECTED] via RT
Hi, This is now done (r15025). Jonathan

[perl #40598] [PATCH] Make perlcritic.t barf more nicely when Test::Perl::Critic not installed

2006-10-26 Thread Paul Cochrane
# New Ticket Created by "Paul Cochrane" # Please include the string: [perl #40598] # in the subject line of all future correspondence about this issue. # http://rt.perl.org/rt3/Ticket/Display.html?id=40598 > Hi, this patch ensures that when t/codingstd/perlcritic.t can't find Test::Perl::Cri

[perl #40599] [NEW] Coding standards test of return statements

2006-10-26 Thread Paul Cochrane
# New Ticket Created by "Paul Cochrane" # Please include the string: [perl #40599] # in the subject line of all future correspondence about this issue. # http://rt.perl.org/rt3/Ticket/Display.html?id=40599 > Hi, This file is actually a hack of the C sub in C and checks that return statements

Re: [perl #40443] Separate vtable functions from methods (using :vtable)

2006-10-26 Thread Patrick R. Michaud
On Wed, Oct 25, 2006 at 11:02:59PM -0700, Allison Randal wrote: > [EMAIL PROTECTED] via RT wrote: > >On Sun Oct 01 16:22:10 2006, mdiep wrote: > >>At the OSCON 2006 Hackathon, it was decided that we should separate > >>vtables from methods and add a new :vtable label for PIR subs to mark > >>th

Re: [perl #40598] [PATCH] Make perlcritic.t barf more nicely when Test::Perl::Critic not installed

2006-10-26 Thread Chris Dolan
On Oct 26, 2006, at 5:21 AM, Paul Cochrane (via RT) wrote: this patch ensures that when t/codingstd/perlcritic.t can't find Test::Perl::Critic, that instead of exiting with a "Can't locate Test/Perl/Critic.pm in @INC" compile-time error, it reports that it is skipping the test with the message d

Re: [perl #40598] [PATCH] Make perlcritic.t barf more nicely when Test::Perl::Critic not installed

2006-10-26 Thread Paul Cochrane
A better implementation of that patch would be: BEGIN { eval { require Test::Perl::Critic; }; if ($@) { plan skip_all => 'Test::Perl::Critic not installed'; } Test::Perl::Critic->import(-verbose => 7); Thanks Chris! I didn't know how to maintain the verbose f

[perl #40443] Separate vtable functions from methods (using :vtable)

2006-10-26 Thread [EMAIL PROTECTED] via RT
Hi, Thanks Allison for clarifications and @other for agreement; I've taken this ticket and will get cracking on implementing this. Jonathan