Re: [REPATCH] Re: [PATCH] Bash some more warnings

2002-02-20 Thread Simon Cozens
Josh Wilmes: > Any chance of getting this in some time soon? The key.c part of it fixes > the broken tcc (and probably lcc) builds. All tests passed with tcc for > me, which is neat. Most of key.c's about to die anyway, so I don't consider that particularly important. OTOH, having non-broken

Re: [REPATCH] Re: [PATCH] Bash some more warnings

2002-02-19 Thread Josh Wilmes
Any chance of getting this in some time soon? The key.c part of it fixes the broken tcc (and probably lcc) builds. All tests passed with tcc for me, which is neat. --Josh At 21:06 on 02/18/2002 GMT, Jonathan Stowe <[EMAIL PROTECTED]> wrote: > On Mon, 18 Feb 2002, Dan Sugalski wrote: > > >

[REPATCH] Re: [PATCH] Bash some more warnings

2002-02-18 Thread Jonathan Stowe
On Mon, 18 Feb 2002, Dan Sugalski wrote: > > I think I'd rather we did have the cast in there. If nothing else, > it'll help us note where we've cast incorrectly and, while that might > just be an error in the casting, it might also indicate an error in > the logic. > OK, this is a roundup of th

Re: [PATCH] Bash some more warnings

2002-02-18 Thread Dan Sugalski
At 1:21 PM +0100 2/17/02, Segher Boessenkool wrote: >Steve Fink wrote: >> >> > - key->keys = (KEY_PAIR*)realloc(key->keys,sizeof(KEY_PAIR)*size); >> > + key->keys = (KEY_PAIR**)realloc(key->keys,sizeof(KEY_PAIR)*size); >> >> That seems rather suspicious. I don't know anything about th

Re: [PATCH] Bash some more warnings

2002-02-18 Thread Jonathan Stowe
On Sun, 17 Feb 2002, Segher Boessenkool wrote: > > > Steve Fink wrote: > > > > > - key->keys = (KEY_PAIR*)realloc(key->keys,sizeof(KEY_PAIR)*size); > > > + key->keys = (KEY_PAIR**)realloc(key->keys,sizeof(KEY_PAIR)*size); > > > > That seems rather suspicious. I don't know anything about

Re: [PATCH] Bash some more warnings

2002-02-17 Thread Segher Boessenkool
Steve Fink wrote: > > > - key->keys = (KEY_PAIR*)realloc(key->keys,sizeof(KEY_PAIR)*size); > > + key->keys = (KEY_PAIR**)realloc(key->keys,sizeof(KEY_PAIR)*size); > > That seems rather suspicious. I don't know anything about the KEY_PAIR > type, but allocating a chunk of memory big e

[REPATCH] Re: [PATCH] Bash some more warnings

2002-02-17 Thread Jonathan Stowe
On Sat, 16 Feb 2002, Steve Fink wrote: > > - key->keys = (KEY_PAIR*)realloc(key->keys,sizeof(KEY_PAIR)*size); > > + key->keys = (KEY_PAIR**)realloc(key->keys,sizeof(KEY_PAIR)*size); > > That seems rather suspicious. I don't know anything about the KEY_PAIR > type, but allocating a chunk

Re: [PATCH] Bash some more warnings

2002-02-16 Thread Steve Fink
> - key->keys = (KEY_PAIR*)realloc(key->keys,sizeof(KEY_PAIR)*size); > + key->keys = (KEY_PAIR**)realloc(key->keys,sizeof(KEY_PAIR)*size); That seems rather suspicious. I don't know anything about the KEY_PAIR type, but allocating a chunk of memory big enough to fit N structures and the

[PATCH] Bash some more warnings

2002-02-16 Thread Jonathan Stowe
Index: embed.c === RCS file: /home/perlcvs/parrot/embed.c,v retrieving revision 1.10 diff -u -r1.10 embed.c --- embed.c 15 Feb 2002 02:30:02 - 1.10 +++ embed.c 16 Feb 2002 11:21:17 - @@ -129,7 +129,7 @@ pf =