Re: [PATCH] Constant Access Macros (version 2)

2001-10-02 Thread Jason Gloudon
On Tue, Oct 02, 2001 at 07:50:39AM -0400, Gregor N. Purdy wrote: > All -- > > > + >s/NUM_CONST\(([^)]+)\)/interpreter->code->const_table->constants[$1]->number/g; > > + >s/STR_CONST\(([^)]+)\)/interpreter->code->const_table->constants[$1]->string/g; > > + >s/INT_CONST\(([^)]+)\)/inter

Re: [PATCH] Constant Access Macros (version 2)

2001-10-02 Thread Gregor N. Purdy
All -- > +s/NUM_CONST\(([^)]+)\)/interpreter->code->const_table->constants[$1]->number/g; > +s/STR_CONST\(([^)]+)\)/interpreter->code->const_table->constants[$1]->string/g; > +s/INT_CONST\(([^)]+)\)/interpreter->code->const_table->constants[$1]->string/g; I just committed a fix for I

Re: [PATCH] Constant Access Macros (version 2)

2001-10-02 Thread Simon Cozens
On Tue, Oct 02, 2001 at 07:36:39AM -0400, Jason Gloudon wrote: > This patch removes the preprocessor macros for register access. These are now > substituted in basic_opcodes.ops by process_opfunc. The patch also adds > substitution for NUM_CONST(), STR_CONST(), INT_CONST() for constant access in >

[PATCH] Constant Access Macros (version 2)

2001-10-02 Thread Jason Gloudon
On Mon, Oct 01, 2001 at 03:27:49PM +0100, Simon Cozens wrote: > On Mon, Oct 01, 2001 at 10:23:11AM -0400, Jason Gloudon wrote: > > What about the current macros for NUM_REG etc ? > > I'd probably rip 'em out too. Stops people accidentally hand hacking the .c file > instead of the .ops file and th

Re: [PATCH] Constant Access Macros

2001-10-01 Thread Dan Sugalski
At 03:27 PM 10/1/2001 +0100, Simon Cozens wrote: >On Mon, Oct 01, 2001 at 10:23:11AM -0400, Jason Gloudon wrote: > > What about the current macros for NUM_REG etc ? > >I'd probably rip 'em out too. Stops people accidentally hand hacking the >.c file >instead of the .ops file and then losing all t

Re: [PATCH] Constant Access Macros

2001-10-01 Thread Simon Cozens
On Mon, Oct 01, 2001 at 10:23:11AM -0400, Jason Gloudon wrote: > What about the current macros for NUM_REG etc ? I'd probably rip 'em out too. Stops people accidentally hand hacking the .c file instead of the .ops file and then losing all their changes on rebuild. Not that I've ever done that tri

Re: [PATCH] Constant Access Macros

2001-10-01 Thread Simon Cozens
On Sun, Sep 30, 2001 at 11:37:37PM -0400, Jason Gloudon wrote: > Here is a patch for macros for accessing constants from ops. This uses > (INT|STR|NUM)_PCONST(i) for the relevant types. Best to avoid filling opcode > definitions with manual structure dereferences. Nice idea, but I'd *much* rathe

[PATCH] Constant Access Macros

2001-09-30 Thread Jason Gloudon
On Sun, Sep 30, 2001 at 11:31:21AM -0400, Gregor N. Purdy wrote: > And, BTW, the current PackFile_Constant type isn't using a union. > It has separate members for each type of constant. This could be > changed once things are working. There's probably a few other > things that could use some cle