Re: [PATCH] Re: [perl #50684] String Failures with -O2 (GCC 4.1.3, 32-bit x86 Linux)

2008-03-12 Thread Andy Lester
On Mar 12, 2008, at 2:33 PM, Andy Dougherty via RT wrote: +#ifdef HASATTRIBUTE_NONNULL_AND_I_REALLY_WANT_TO_USE_IT # define __attribute__nonnull__(a) __attribute__((__nonnull__(a))) #endif #ifdef HASATTRIBUTE_NORETURN and suddenly (for some value of suddenly that is more like an

[PATCH] Re: [perl #50684] String Failures with -O2 (GCC 4.1.3, 32-bit x86 Linux)

2008-03-12 Thread Andrew Dougherty
[various thoughts on attribute_nonnull] On a lark, I applied this patch: --- parrot-current/include/parrot/compiler.hTue Mar 11 07:19:23 2008 +++ parrot-andy/include/parrot/compiler.h Wed Mar 12 13:22:42 2008 @@ -44,7 +44,7 @@ #ifdef HASATTRIBUTE_MALLOC # define

Re: [PATCH] Re: [perl #50684] String Failures with -O2 (GCC 4.1.3, 32-bit x86 Linux)

2008-03-12 Thread Andy Dougherty
On Wed, 12 Mar 2008, Andy Lester wrote: On Mar 12, 2008, at 2:33 PM, Andy Dougherty via RT wrote: +#ifdef HASATTRIBUTE_NONNULL_AND_I_REALLY_WANT_TO_USE_IT # define __attribute__nonnull__(a) __attribute__((__nonnull__(a))) #endif #ifdef HASATTRIBUTE_NORETURN and suddenly

Re: [PATCH] Re: [perl #50684] String Failures with -O2 (GCC 4.1.3, 32-bit x86 Linux)

2008-03-12 Thread Andy Lester
On Mar 12, 2008, at 4:50 PM, Andy Dougherty via RT wrote: The problem is twofold: I'm not sure what you're saying is a problem. Are you saying that the use of __attribute__nonnull__ is a problem? Or just that we don't have it set correctly everywhere? When we DO get it fixed right,

Re: [PATCH] Re: [perl #50684] String Failures with -O2 (GCC 4.1.3, 32-bit x86 Linux)

2008-03-12 Thread chromatic
On Wednesday 12 March 2008 15:07:08 Andy Lester wrote: On Mar 12, 2008, at 4:50 PM, Andy Dougherty via RT wrote: The problem is twofold: I'm not sure what you're saying is a problem. Are you saying that the use of __attribute__nonnull__ is a problem? Or just that we don't have it set

Re: [PATCH] Re: [perl #50684] String Failures with -O2 (GCC 4.1.3, 32-bit x86 Linux)

2008-03-12 Thread Andy Dougherty
On Wed, 12 Mar 2008, chromatic wrote: On Wednesday 12 March 2008 15:07:08 Andy Lester wrote: On Mar 12, 2008, at 4:50 PM, Andy Dougherty via RT wrote: The problem is twofold: I'm not sure what you're saying is a problem. Are you saying that the use of __attribute__nonnull__ is a