[perl #16144] [PATCH] quotematch speedup

2002-08-12 Thread via RT
# New Ticket Created by jryan # Please include the string: [perl #16144] # in the subject line of all future correspondence about this issue. # URL: http://rt.perl.org/rt2/Ticket/Display.html?id=16144 Small speed patch for assemble.pl here... Benchmarks that I've done show that the new

Re: [perl #16144] [PATCH] quotematch speedup

2002-08-12 Thread Nicholas Clark
On Mon, Aug 12, 2002 at 01:56:49PM +, jryan wrote: # New Ticket Created by jryan # Please include the string: [perl #16144] # in the subject line of all future correspondence about this issue. # URL: http://rt.perl.org/rt2/Ticket/Display.html?id=16144 Small speed patch for

Re: [perl #16144] [PATCH] quotematch speedup

2002-08-12 Thread Simon Cozens
[EMAIL PROTECTED] (Nicholas Clark) writes: Well, I find assemble.pl too slow, so I like speed. Good grief. Maybe someone should implement it in XS; then as well as being fast, we'd avoid duplicating code from the core, and we'd have the basis of a bytecode emission library that things compiling

Re: [perl #16144] [PATCH] quotematch speedup

2002-08-12 Thread Nicholas Clark
On Mon, Aug 12, 2002 at 04:01:13PM +0100, Simon Cozens wrote: [EMAIL PROTECTED] (Nicholas Clark) writes: Well, I find assemble.pl too slow, so I like speed. Good grief. Maybe someone should implement it in XS; then as well as being fast, we'd avoid duplicating code from the core, and we'd

Re: [perl #16144] [PATCH] quotematch speedup

2002-08-12 Thread Simon Cozens
Nicholas Clark: Specifically: Why are we back to a single file assembler in pure perl? Why is it being proposed to be split up again? Are we going round in circles, or do the changes represent a spiral? My design decisions for what *I* did, in rewriting the original assembler: 1)

Re: [perl #16144] [PATCH] quotematch speedup

2002-08-12 Thread Daniel Grunblatt
On Mon, 12 Aug 2002, Simon Cozens wrote: It's my opinion that it went from there back to pure-Perl because people here are happier handling pure Perl than XS. Jeff may have to correct me on that. I moved it back to pure-Perl because there were something like half of the tinderboxes failing to

Re: [perl #16144] [PATCH] quotematch speedup

2002-08-12 Thread Daniel Grunblatt
On 12 Aug 2002, Simon Cozens wrote: [EMAIL PROTECTED] (Daniel Grunblatt) writes: I moved it back to pure-Perl because there were something like half of the tinderboxes failing to assemble anything. Ah, right. Yeah, the tinderboxes are good slaves but really bad masters. True, but I was

Re: [perl #16144] [PATCH] quotematch speedup

2002-08-12 Thread Juergen Boemmels
jryan (via RT) [EMAIL PROTECTED] writes: --- assemble_old.pl 2002-08-04 21:00:02.0 -0400 +++ assemble.pl 2002-08-12 00:03:56.0 -0400 @@ -263,8 +263,8 @@ sub preprocess { } elsif(/^\.constant \s+ ($label_re) \s+ -