Re: [perl #17817] [PATCH] Parrot_sprintf-related stuff, part 2

2002-10-11 Thread Steve Fink
On Thu, Oct 10, 2002 at 09:57:01AM -0400, Andy Dougherty wrote: On Wed, 9 Oct 2002, Brent Dax wrote: Can you try this? (at the top of the function...) va_list *arg = (va_list *) (obj-data); (vararg accesses should look like...) va_arg(*arg, ...); (no

Re: [perl #17817] [PATCH] Parrot_sprintf-related stuff, part 2

2002-10-11 Thread Dan Sugalski
At 9:11 AM -0700 10/11/02, Steve Fink wrote: Brent, what do you need to help work this out? Is there anyone out there who could loan a PPC account to Brent, or perhaps be familiar enough with stdarg to take a look directly? (Or how about some grizzled grayhair who can tell us if this approach is

RE: [perl #17817] [PATCH] Parrot_sprintf-related stuff, part 2

2002-10-11 Thread Brent Dax
Andy Dougherty: # On Wed, 9 Oct 2002, Brent Dax wrote: # # Can you try this? # # (at the top of the function...) # va_list *arg = (va_list *) (obj-data); # (vararg accesses should look like...) # va_arg(*arg, ...); # (no end-of-function assignment should be

RE: [perl #17817] [PATCH] Parrot_sprintf-related stuff, part 2

2002-10-11 Thread Brent Dax
Brent Dax: # Can someone with a PPC box try to figure out why this is happening? # # /op/string.# Failed test (t/op/string.t at line # 1224) # # got: '-1.13014e-302 # # -1.13014e-302 # # ' # # expected: '80.43 # # -1.1 # # '

Re: [perl #17817] [PATCH] Parrot_sprintf-related stuff, part 2

2002-10-11 Thread Andy Dougherty
Brent, what do you need to help work this out? Is there anyone out there who could loan a PPC account to Brent, or perhaps be familiar enough with stdarg to take a look directly? (Or how about some grizzled grayhair who can tell us if this approach is doomed for portability reasons? Not

RE: [perl #17817] [PATCH] Parrot_sprintf-related stuff, part 2

2002-10-11 Thread Dan Sugalski
At 12:25 PM -0700 10/11/02, Brent Dax wrote: Argh. It looks like all the tests on PPC with the varargs core are failing, but the test with the PMC core (t/op/string.t #96) isn't. I don't get it--are they *trying* to make varargs impossible to use?!? No, that's just a happy side-effect. :)

RE: [perl #17817] [PATCH] Parrot_sprintf-related stuff, part 2

2002-10-10 Thread Brent Dax
Andy Dougherty: # You'll probably also want the enhanced sprintf tests (or # something like # them.) Currently, the only one that fails for me is the # %5.3f test, which gives 0.500 in stdio, but # 0.5 from Parrot. I finally tracked down this bug. If you

RE: [perl #17817] [PATCH] Parrot_sprintf-related stuff, part 2

2002-10-10 Thread Andy Dougherty
On Wed, 9 Oct 2002, Brent Dax wrote: Can you try this? (at the top of the function...) va_list *arg = (va_list *) (obj-data); (vararg accesses should look like...) va_arg(*arg, ...); (no end-of-function assignment should be necessary) If that works for

Re: [perl #17817] [PATCH] Parrot_sprintf-related stuff, part 2

2002-10-10 Thread Andy Dougherty
On Wed, 9 Oct 2002, Nicholas Clark wrote: Which reminds me, not sure if this is relevant yet, but there's some or other platform that p5p encountered that can't simply copy whatever it is the opaque type va_list expands to there. There's a perl5 Configure symbol need_va_copy which

[perl #17817] [PATCH] Parrot_sprintf-related stuff, part 2

2002-10-09 Thread via RT
# New Ticket Created by Brent Dax # Please include the string: [perl #17817] # in the subject line of all future correspondence about this issue. # URL: http://rt.perl.org/rt2/Ticket/Display.html?id=17817 Inspiration struck me as I was working on bug fixes for Parrot_sprintf's patch

Re: [perl #17817] [PATCH] Parrot_sprintf-related stuff, part 2

2002-10-09 Thread Andy Dougherty
On Wed, 9 Oct 2002, Brent Dax wrote: [Brent continues to churn out amazing quantities of good stuff] Overall, it continues to look very good. Unfortunately, the compact-looking ch=va_arg((va_list)obj-data, char); gave Sun's compiler indigestion. I had to split it up into the much more

RE: [perl #17817] [PATCH] Parrot_sprintf-related stuff, part 2

2002-10-09 Thread Brent Dax
Andy Dougherty: # Overall, it continues to look very good. Unfortunately, the # compact-looking # # ch=va_arg((va_list)obj-data, char); # # gave Sun's compiler indigestion. I had to split it up into # the much more pedestrian # # va_list arg; # arg = (va_list) obj-data; #

RE: [perl #17817] [PATCH] Parrot_sprintf-related stuff, part 2

2002-10-09 Thread Andy Dougherty
On Wed, 9 Oct 2002, Brent Dax wrote: Andy Dougherty: # Overall, it continues to look very good. Unfortunately, the # compact-looking # # ch=va_arg((va_list)obj-data, char); # # gave Sun's compiler indigestion. I had to split it up into # the much more pedestrian # #

RE: [perl #17817] [PATCH] Parrot_sprintf-related stuff, part 2

2002-10-09 Thread Andy Dougherty
On Wed, 9 Oct 2002, Andy Dougherty wrote: # Unfortunately, the compact-looking # # ch=va_arg((va_list)obj-data, char); # # gave Sun's compiler indigestion. Hmm. Just removing the (va_list) cast makes both Sun's compiler and gcc happy. (That's because va_list is ultimately

RE: [perl #17817] [PATCH] Parrot_sprintf-related stuff, part 2

2002-10-09 Thread Andy Dougherty
On Wed, 9 Oct 2002, Andy Dougherty wrote: diff -r -u parrot-orig/t/src/sprintf.t parrot-andy/t/src/sprintf.t + dval = 1.0e6; + S = Parrot_sprintf_c(interpreter, == %g\n, dval); + printf(%g %s, dval, string_to_cstring(interpreter, S)); Aargh. I forgot

Re: [perl #17817] [PATCH] Parrot_sprintf-related stuff, part 2

2002-10-09 Thread Nicholas Clark
On Wed, Oct 09, 2002 at 04:42:36PM -0400, Andy Dougherty wrote: On Wed, 9 Oct 2002, Andy Dougherty wrote: diff -r -u parrot-orig/t/src/sprintf.t parrot-andy/t/src/sprintf.t + dval = 1.0e6; + S = Parrot_sprintf_c(interpreter, == %g\n, dval); + printf(%g