[perl #40361] [PATCH] #40278 [CAGE] perl coding standards coda. (cont.)

2006-09-30 Thread Will Coleda via RT
On Tue Sep 19 10:10:45 2006, [EMAIL PROTECTED] wrote: > On Tuesday 19 September 2006 07:56, jerry gay wrote: > > > ~  all non-perl test files must have a shebang > > > > i strongly suggest that this be extended to cover all test files. > > then, as you say, it can easily be tested, and it's value

[perl #40361] [PATCH] #40278 [CAGE] perl coding standards coda. (cont.)

2006-11-15 Thread Paul Cochrane via RT
Hi all, The attached patch to the coding standards pdd concerns how we handle the parrot emacs/vim coda in perl source files when the files contain __END__ or __DATA__ blocks. The reason for the patch is that vim looks at only the first or last five lines of a file to see if there is any styl

[perl #40361] [PATCH] #40278 [CAGE] perl coding standards coda. (cont.)

2006-12-16 Thread Paul Cochrane via RT
Hi all, We could close this ticket if a decision were made as to whether or not the emacs/vim formatting information can be put at the *beginning* of a file in the case where __END__ or __DATA__ blocks are used within a perl source file. What are people's opinions? Would it be too ugly to p

[perl #40361] [PATCH] #40278 [CAGE] perl coding standards coda. (cont.)

2007-04-01 Thread Paul Cochrane via RT
On Tue Dec 19 16:30:34 2006, [EMAIL PROTECTED] wrote: > Nicholas Clark wrote: > > > > To seek clarification - having those as global settings for cperl isn't > > likely to be an issue? Or having them in editor blocks? > > I meant globally. > > It's really not a big deal, though. For the immedia

Re: [perl #40361] [PATCH] #40278 [CAGE] perl coding standards coda. (cont.)

2006-09-19 Thread jerry gay
On 9/19/06, via RT Paul Cochrane <[EMAIL PROTECTED]> wrote: # New Ticket Created by "Paul Cochrane" # Please include the string: [perl #40361] # in the subject line of all future correspondence about this issue. # http://rt.perl.org/rt3/Ticket/Display.html?id=40361 > This is a patch of more Pe

Re: [perl #40361] [PATCH] #40278 [CAGE] perl coding standards coda. (cont.)

2006-09-19 Thread Paul Cochrane
Jerry, firstly, line endings are unrelated to this effort and should be a separate patch. that's no biggie, and alone wouldn't stop me from applying. I can do that in a separate patch if you want. That's not a major problem, and probably a good idea. I'd not realised some of the issues you b

Re: [perl #40361] [PATCH] #40278 [CAGE] perl coding standards coda. (cont.)

2006-09-19 Thread jerry gay
On 9/19/06, Paul Cochrane <[EMAIL PROTECTED]> wrote: > firstly, line endings are unrelated to this effort and should be a > separate patch. that's no biggie, and alone wouldn't stop me from > applying. I can do that in a separate patch if you want. That's not a major problem, and probably a good

Re: [perl #40361] [PATCH] #40278 [CAGE] perl coding standards coda. (cont.)

2006-09-19 Thread Paul Cochrane
Jerry, oh, and yes, i believe the shebang should be in all perl files... but this isn't specified *yet* in pdd07. if you can enter the ticket, that would be fantastic, and we'll get a ruling from chip. This is going to sound rather silly, but... how does one enter a new ticket to RT? I've got

Re: [perl #40361] [PATCH] #40278 [CAGE] perl coding standards coda. (cont.)

2006-09-19 Thread jerry gay
On 9/19/06, Paul Cochrane <[EMAIL PROTECTED]> wrote: This is going to sound rather silly, but... how does one enter a new ticket to RT? I've got an account, but can't see anywhere on rt.perl.org where one can add a new ticket. There's also no help link I can go to to work out what to do. Shou

Re: [perl #40361] [PATCH] #40278 [CAGE] perl coding standards coda. (cont.)

2006-09-19 Thread Paul Cochrane
Jerry, all new rt tickets are created via parrotbug. it may not be sexy, but it's what we've got :-) I'm not 100% sure if it worked, as parrotbug gave this warning: Use of uninitialized value in concatenation (.) or string at ./parrotbug line 525, line 7. and the ticket doesn't seem to have

Re: [perl #40361] [PATCH] #40278 [CAGE] perl coding standards coda. (cont.)

2006-09-19 Thread jerry gay
On 9/19/06, Paul Cochrane <[EMAIL PROTECTED]> wrote: Jerry, > all new rt tickets are created via parrotbug. it may not be sexy, but > it's what we've got :-) I'm not 100% sure if it worked, as parrotbug gave this warning: Use of uninitialized value in concatenation (.) or string at ./parrotbug

Re: [perl #40361] [PATCH] #40278 [CAGE] perl coding standards coda. (cont.)

2006-09-19 Thread chromatic
On Tuesday 19 September 2006 07:56, jerry gay wrote: > ~  all non-perl test files must have a shebang > > i strongly suggest that this be extended to cover all test files. > then, as you say, it can easily be tested, and it's value can be used > in other tests to determine it's file type. if you w

Re: [perl #40361] [PATCH] #40278 [CAGE] perl coding standards coda. (cont.)

2006-10-16 Thread Paul Cochrane
Hi, This patch changes the semantics of the checking for the Perl code coda in Perl::Critic::Policy::CodeLayout::UseParrotCoda. At present the Perl code coda is checked at the end of the file if no __END__ or __DATA__ block is present, and is checked before the __END__ or __DATA__ block if such

Re: [perl #40361] [PATCH] #40278 [CAGE] perl coding standards coda. (cont.)

2006-12-17 Thread Chris Dolan
On Dec 16, 2006, at 12:41 PM, Paul Cochrane via RT wrote: Hi all, We could close this ticket if a decision were made as to whether or not the emacs/vim formatting information can be put at the *beginning* of a file in the case where __END__ or __DATA__ blocks are used within a perl source

Re: [perl #40361] [PATCH] #40278 [CAGE] perl coding standards coda. (cont.)

2006-12-17 Thread Bob Rogers
From: Chris Dolan <[EMAIL PROTECTED]> Date: Sun, 17 Dec 2006 13:22:53 -0600 On Dec 16, 2006, at 12:41 PM, Paul Cochrane via RT wrote: > Hi all, > > We could close this ticket if a decision were made as to whether or > not > the emacs/vim formatting information can be put

Re: [perl #40361] [PATCH] #40278 [CAGE] perl coding standards coda. (cont.)

2006-12-17 Thread Bob Rogers
From: Bob Rogers <[EMAIL PROTECTED]> Date: Sun, 17 Dec 2006 15:03:10 -0500 From: Chris Dolan <[EMAIL PROTECTED]> Date: Sun, 17 Dec 2006 13:22:53 -0600 . . . Be aware that you cannot use the verbose form of Emacs settings at the beginning of a file, unless th

Re: [perl #40361] [PATCH] #40278 [CAGE] perl coding standards coda. (cont.)

2006-12-17 Thread Paul Cochrane
Be aware that you cannot use the verbose form of Emacs settings at the beginning of a file, unless the file is shorter than 3000 bytes. See Perl::Critic::Policy::Editor::RequireEmacsFileVariables policy for more details: So this means we need to put the emacs and vim settings at the end of the f

Re: [perl #40361] [PATCH] #40278 [CAGE] perl coding standards coda. (cont.)

2006-12-18 Thread Chris Dolan
On Dec 18, 2006, at 1:57 AM, Paul Cochrane wrote: Be aware that you cannot use the verbose form of Emacs settings at the beginning of a file, unless the file is shorter than 3000 bytes. See Perl::Critic::Policy::Editor::RequireEmacsFileVariables policy for more details: So this means we need t

Re: [perl #40361] [PATCH] #40278 [CAGE] perl coding standards coda. (cont.)

2006-12-19 Thread Allison Randal
Paul Cochrane wrote: The problem that I'm trying to solve here is: how do we add the settings information to perl language files such that it doesn't cause problems with __END__ and __DATA__ blocks, is testable by perlcritic, emacs *and* vim pick up their settings values, and it doesn't interfer

Re: [perl #40361] [PATCH] #40278 [CAGE] perl coding standards coda. (cont.)

2006-12-19 Thread Lee Duhem
My vote is on removing all emacs and vim settings from our source code files. and so you can get really bad code appearance.

Re: [perl #40361] [PATCH] #40278 [CAGE] perl coding standards coda. (cont.)

2006-12-19 Thread Patrick R. Michaud
On Tue, Dec 19, 2006 at 05:20:06PM +0800, Lee Duhem wrote: > Allison wrote: > >My vote is on removing all emacs and vim settings from our source code > >files. > and so you can get really bad code appearance. I'm curious, why is that? We're already discouraging (if not disallowing) hard tabs in t

Re: [perl #40361] [PATCH] #40278 [CAGE] perl coding standards coda. (cont.)

2006-12-19 Thread Paul Cochrane
Having editor hints in the source can have value as it can reduce the cage cleaning load by getting the editor to indent people's code consistently (admittedly this only helps people who use emacs and vim in this case) so in that sense it is worthwhile having them around. The coda is added to all

Re: [perl #40361] [PATCH] #40278 [CAGE] perl coding standards coda. (cont.)

2006-12-19 Thread Allison Randal
Paul Cochrane wrote: Having editor hints in the source can have value as it can reduce the cage cleaning load by getting the editor to indent people's code consistently (admittedly this only helps people who use emacs and vim in this case) so in that sense it is worthwhile having them around. The

Re: [perl #40361] [PATCH] #40278 [CAGE] perl coding standards coda. (cont.)

2006-12-19 Thread chromatic
On Tuesday 19 December 2006 10:05, Allison Randal wrote: > The editor hints aren't actually very helpful, but they do add clutter > to every source file, and a maintenance burden. Both vim and emacs allow > top-level settings of these preferences, which is a more appropriate > place for them. I a

Re: [perl #40361] [PATCH] #40278 [CAGE] perl coding standards coda. (cont.)

2006-12-19 Thread Nicholas Clark
On Tue, Dec 19, 2006 at 10:05:46AM -0800, Allison Randal wrote: > to every source file, and a maintenance burden. Both vim and emacs allow > top-level settings of these preferences, which is a more appropriate > place for them. This assumes that all the projects you use the editor for have the

Re: [perl #40361] [PATCH] #40278 [CAGE] perl coding standards coda. (cont.)

2006-12-19 Thread Allison Randal
Nicholas Clark wrote: On Tue, Dec 19, 2006 at 10:05:46AM -0800, Allison Randal wrote: to every source file, and a maintenance burden. Both vim and emacs allow top-level settings of these preferences, which is a more appropriate place for them. This assumes that all the projects you use the e

Re: [perl #40361] [PATCH] #40278 [CAGE] perl coding standards coda. (cont.)

2006-12-19 Thread Nicholas Clark
On Tue, Dec 19, 2006 at 01:08:14PM -0800, Allison Randal wrote: > Nicholas Clark wrote: > >On Tue, Dec 19, 2006 at 10:05:46AM -0800, Allison Randal wrote: > > > >>to every source file, and a maintenance burden. Both vim and emacs allow > >>top-level settings of these preferences, which is a more a

Re: [perl #40361] [PATCH] #40278 [CAGE] perl coding standards coda. (cont.)

2006-12-19 Thread Allison Randal
Nicholas Clark wrote: To seek clarification - having those as global settings for cperl isn't likely to be an issue? Or having them in editor blocks? I meant globally. It's really not a big deal, though. For the immediate problem, let's just make an exception and leave the hints out of Perl

Re: [perl #40361] [PATCH] #40278 [CAGE] perl coding standards coda. (cont.)

2006-12-19 Thread Lee Duhem
All it does is turn on cperl mode for emacs, and set tabs to 4 spaces for vim and emacs. Not likely to significantly interfere with any repository you work on. (I actually gave up on the tab key in vim years ago. I type literal spaces, and my brain automatically adjusts my indenting to the surroun

Re: [perl #40361] [PATCH] #40278 [CAGE] perl coding standards coda. (cont.)

2006-12-19 Thread Paul Cochrane
It's really not a big deal, though. For the immediate problem, let's just make an exception and leave the hints out of Perl files with __END__ or __DATA__ blocks. Sounds good. I can update the Perl::Critic policy, and make a note in pdd07. Mark it as a cage cleaner task for some point down the

Re: [perl #40361] [PATCH] #40278 [CAGE] perl coding standards coda. (cont.)

2006-12-20 Thread Nicholas Clark
On Tue, Dec 19, 2006 at 04:30:08PM -0800, Allison Randal wrote: > Nicholas Clark wrote: > > > >To seek clarification - having those as global settings for cperl isn't > >likely to be an issue? Or having them in editor blocks? > > I meant globally. Ah. There have been times when it would have been