Re: [perl #46099] [TODO] Check for existing parent classes in add_parent()

2007-10-16 Thread Allison Randal
Klaas-Jan Stol via RT wrote: Hi, the patch I provided has not yet been reviewed or applied. Could anybody have a look at it? It'll only take 5 minutes or so. If it's ok, it can be applied before this month's release, and this ticket can be closed. Applied now in the PDD 15 branch, together wit

[perl #46099] [TODO] Check for existing parent classes in add_parent()

2007-10-14 Thread Klaas-Jan Stol via RT
Hi, the patch I provided has not yet been reviewed or applied. Could anybody have a look at it? It'll only take 5 minutes or so. If it's ok, it can be applied before this month's release, and this ticket can be closed. Thanks in advance, kjs On Mon Oct 08 06:50:29 2007, kjs wrote: > On 10/8/07,

Re: [perl #46099] [TODO] Check for existing parent classes in add_parent()

2007-10-08 Thread Klaas-Jan Stol
On 10/8/07, Klaas-Jan Stol <[EMAIL PROTECTED]> wrote: > > > > On 10/8/07, Allison Randal <[EMAIL PROTECTED]> wrote: > > > > Klaas-Jan Stol wrote: > > > I think it should be something like this: > > > > > > /* RT46099 Check we don't already have this parent. */ > > > > > > /* If we ha

Re: [perl #46099] [TODO] Check for existing parent classes in add_parent()

2007-10-08 Thread Klaas-Jan Stol
On 10/8/07, Allison Randal <[EMAIL PROTECTED]> wrote: > > Klaas-Jan Stol wrote: > > I think it should be something like this: > > > > /* RT46099 Check we don't already have this parent. */ > > > > /* If we have already added a method with this name... */ > > if (VTABLE_exists

Re: [perl #46099] [TODO] Check for existing parent classes in add_parent()

2007-10-07 Thread Allison Randal
Klaas-Jan Stol wrote: I think it should be something like this: /* RT46099 Check we don't already have this parent. */ /* If we have already added a method with this name... */ if (VTABLE_exists_keyed_str(interp, _class->all_parents, VTABLE_name(interp, parent))) {

Re: [perl #46099] [TODO] Check for existing parent classes in add_parent()

2007-10-06 Thread Klaas-Jan Stol
I think it should be something like this: /* RT46099 Check we don't already have this parent. */ /* If we have already added a method with this name... */ if (VTABLE_exists_keyed_str(interp, _class->all_parents, VTABLE_name(interp, parent))) { real_exception(int

[perl #46099] [TODO] Check for existing parent classes in add_parent()

2007-10-04 Thread via RT
# New Ticket Created by Paul Cochrane # Please include the string: [perl #46099] # in the subject line of all future correspondence about this issue. # http://rt.perl.org/rt3/Ticket/Display.html?id=46099 > In src/pmc/class.pmc:add_parent() there is the todo item: /* XXX Check we don't alread