Re: [PATCH] Perlhash fix & test (was Re: Eliminate padding warnings)

2002-10-10 Thread Steve Fink
Thanks, applied.

Re: Eliminate padding warnings

2002-10-10 Thread Tanton Gibbs
> on ARM, lots of these two: > > In file included from ../include/parrot/register.h:16, > from ../include/parrot/interpreter.h:42, > from ../include/parrot/parrot.h:160, > from array.c:27: > .../include/parrot/string.h:59: warning: padding struct

[PATCH] Perlhash fix & test (was Re: Eliminate padding warnings)

2002-10-10 Thread Simon Glover
On Wed, 9 Oct 2002, Tom Hughes wrote: > In message <[EMAIL PROTECTED]> > Simon Glover <[EMAIL PROTECTED]> wrote: > > > I've just had a quick look at hash.h (which I should have done in the > > first place) and you're quite right. Second attempt at a correct patch > > below. > > > >

Re: Eliminate padding warnings

2002-10-09 Thread Tom Hughes
In message <[EMAIL PROTECTED]> Simon Glover <[EMAIL PROTECTED]> wrote: > I've just had a quick look at hash.h (which I should have done in the > first place) and you're quite right. Second attempt at a correct patch > below. > > All tests still pass, but this isn't much comfort, as

Re: Eliminate padding warnings

2002-10-09 Thread Simon Glover
On Wed, 9 Oct 2002, Tom Hughes wrote: > In message <[EMAIL PROTECTED]> > Simon Glover <[EMAIL PROTECTED]> wrote: > > > This one happens because entry is a HASH_ENTRY*, but get_pmc_keyed is > > expecting a PMC*. However, by this point in the function, we've already > > verified that

Re: Eliminate padding warnings

2002-10-09 Thread Tom Hughes
In message <[EMAIL PROTECTED]> Simon Glover <[EMAIL PROTECTED]> wrote: > This one happens because entry is a HASH_ENTRY*, but get_pmc_keyed is > expecting a PMC*. However, by this point in the function, we've already > verified that entry is actually a PMC*, so it should be safe to a

Re: Eliminate padding warnings

2002-10-09 Thread Simon Glover
On Wed, 9 Oct 2002, Nicholas Clark wrote: > On Wed, Oct 09, 2002 at 02:14:50AM -0400, Tanton Gibbs wrote: > > In order, the other significant compiler warnings I see are: > > perlhash.pmc: In function `Parrot_PerlHash_get_pmc_keyed': > perlhash.pmc:192: warning: passing arg 2 of pointer to funct

Re: Eliminate padding warnings

2002-10-09 Thread Nicholas Clark
On Wed, Oct 09, 2002 at 02:14:50AM -0400, Tanton Gibbs wrote: > There were a number of warnings which read something like > "structure padded for alignment of member value in debug.h" > > This can be trivially fixed by reordering the structure members ( I hope). > This patch works fine on cygwin,

Eliminate padding warnings

2002-10-08 Thread Tanton Gibbs
There were a number of warnings which read something like "structure padded for alignment of member value in debug.h" This can be trivially fixed by reordering the structure members ( I hope). This patch works fine on cygwin, but I would like to see some other platforms (especially 64 bit) try it