rename ISLocalToGlobalMapping?

2007-08-28 Thread Lisandro Dalcin
And then {Vec|Mat}SetValuesLocal (after renaming, perhaps to XXXSetValuesMapped) could be implemented in terms of a general mapping. This seems really nice. What do you think? PetscMapping seems a good unification for AO and ISLGM. It should be in the Vec package, right? And it should be a very

rename ISLocalToGlobalMapping?

2007-08-28 Thread Barry Smith
A reason things are they way the are now is that I felt it was important that ISLocalToGlobalMappingApply() be inlineable (since the mapping may be applied to very short arrays of integers). I think it is important to keep this with any redesign. This could be done in the same way

rename ISLocalToGlobalMapping?

2007-08-28 Thread Lisandro Dalcin
On 8/28/07, Barry Smith bsmith at mcs.anl.gov wrote: A reason things are they way the are now is that I felt it was important that ISLocalToGlobalMappingApply() be inlineable I completelly agree with you... Doing this refactorization is a good idea, the PETSc interface will be simplier,

KSPSkipConverged

2007-08-28 Thread Lisandro Dalcin
Does it make sense to change KSPSkipConverged to return KSP_CONVERGED_ITS if iternum==maxit ? KSP_DIVERGED_ITS means convergence failure, but IMHO, KSPSkipConverged should not imply convergence failure (this has implications in SNES). -- Lisandro Dalc?n --- Centro Internacional de

KSPSkipConverged

2007-08-28 Thread Matthew Knepley
Yes, definitely. Go ahead and push it. Matt On 8/28/07, Lisandro Dalcin dalcinl at gmail.com wrote: Does it make sense to change KSPSkipConverged to return KSP_CONVERGED_ITS if iternum==maxit ? KSP_DIVERGED_ITS means convergence failure, but IMHO, KSPSkipConverged should not imply

KSPSkipConverged

2007-08-28 Thread Lisandro Dalcin
On 8/28/07, Matthew Knepley knepley at gmail.com wrote: Yes, definitely. Go ahead and push it. I started to try this by implementing first on petsc4py with petsc-2.3.3-p4, by solving a trivial SPD diagonal system { A_ii = 1/(i+1) } with no PC and maxit=5. Below the results, some things seems

KSPSkipConverged

2007-08-28 Thread Matthew Knepley
On 8/28/07, Lisandro Dalcin dalcinl at gmail.com wrote: On 8/28/07, Matthew Knepley knepley at gmail.com wrote: Yes, definitely. Go ahead and push it. I started to try this by implementing first on petsc4py with petsc-2.3.3-p4, by solving a trivial SPD diagonal system { A_ii = 1/(i+1) }

KSPSkipConverged

2007-08-28 Thread Matthew Knepley
On 8/28/07, Lisandro Dalcin dalcinl at gmail.com wrote: On 8/28/07, Matthew Knepley knepley at gmail.com wrote: Todd's response was that there are reasons it can stop early, like happy breakdown, so we really need to test this with the dev version to track down this behavior. OK, my tests

KSPSkipConverged

2007-08-28 Thread Lisandro Dalcin
On 8/28/07, Matthew Knepley knepley at gmail.com wrote: On 8/28/07, Lisandro Dalcin dalcinl at gmail.com wrote: On 8/28/07, Matthew Knepley knepley at gmail.com wrote: Todd's response was that there are reasons it can stop early, like happy breakdown, so we really need to test this with

KSPSkipConverged

2007-08-28 Thread Lisandro Dalcin
On 8/28/07, Matthew Knepley knepley at gmail.com wrote: I will ask Todd about gltr since it might be supposed to do something funny. You really do not want to look at it. Now I understand way you said that!! Well, let me say that actually GLTR is almost OK, the only two things to remark are: