we should work out a review process that can happen
> before things are pushed to petsc-dev, so that the authors of the patches
> can clean them up in response to comments. When done right, this ends up
> being less work for both the reviewers and the authors.
>
-- next part --
An HTML attachment was scrubbed...
URL:
<http://lists.mcs.anl.gov/pipermail/petsc-dev/attachments/20120824/f22bb3ca/attachment.html>
On Fri, Aug 24, 2012 at 7:16 PM, Hong Zhang wrote:
> Sorry, my sloppiness.
> I should examining it before pushing.
> I'll clean it, and will ask Jie to provide regression tests.
Ok, but how should we review your cleaned up version before you push
anything else?
chances of finding other applications where the method is useful, thus
>> maximizing citations, in case that is the metric you care about.)
>>
>
>
-- next part --
An HTML attachment was scrubbed...
URL:
<http://lists.mcs.anl.gov/pipermail/petsc-dev/attachments/20120824/6dd21c31/attachment.html>
. (This being the lowest possible effort, it maximizes the
> chances of finding other applications where the method is useful, thus
> maximizing citations, in case that is the metric you care about.)
>
-- next part --
An HTML attachment was scrubbed...
URL:
<http://lists.mcs.anl.gov/pipermail/petsc-dev/attachments/20120824/4c925bd9/attachment.html>
iling. (This being the lowest possible effort, it maximizes the
chances of finding other applications where the method is useful, thus
maximizing citations, in case that is the metric you care about.)
-- next part --
An HTML attachment was scrubbed...
URL:
<http://lists.mcs.
; It makes more work for reviewers and the history ends up looking confusing. I
> think we should work out a review process that can happen before things are
> pushed to petsc-dev, so that the authors of the patches can clean them up in
> response to comments. When done right
On 24.08.2012 17:53, Jose E. Roman wrote:
> I guess PETSC_SCALAR should be correctly defined for the case
> complex+__float128 in petscsys.h. Maybe a new PetscDataType
> PETSC___COMPLEX128? This would require changing
> PetscMPIDataTypeToPetscDataType and then PetscBinaryRead...
>
> It is better
El 24/08/2012, a las 13:57, Alexander Grayver escribi?:
> Jose,
>
> Thanks!
>
> One issue. I saw there is special treatment for quad precision in
> PetscBinaryRead:
>
> #if defined(PETSC_USE_REAL___FLOAT128)
> double*ppp;
> #endif
> ...
> #if defined(PETSC_USE_REAL___FLOAT128)
>
>Just make sure it doesn't involve Sean holding the master password for the
> petsc repository and then getting hacked again.
Touch?. I would propose mailing list review so I don't have to leave emacs :-)
On Aug 24, 2012, at 5:42 PM, Jed Brown wrote:
>
> I'm a little concerned that the current review process is all ex post facto.
> It makes more work for reviewers and the history ends up looking confusing. I
> think we should work out a review process that can happen before things are
> pushe
em up in response to comments. When done right, this ends up
being less work for both the reviewers and the authors.
-- next part --
An HTML attachment was scrubbed...
URL:
<http://lists.mcs.anl.gov/pipermail/petsc-dev/attachments/20120824/31130f84/attachment.html>
eir
> experiments lead.
> -- Norbert Wiener
>
>
> --
> Department of Mathematics and Center for Computation & Technology
> Louisiana State University, Baton Rouge, LA 70803, USA
> Tel. +1 (225) 578 1612, Fax +1 (225) 578 4276
> http://www.math.lsu.edu/~bourdin
>
>
>
>
>
>
>
>
>
--
What most experimenters take for granted before they begin their
experiments is infinitely more interesting than any results to which their
experiments lead.
-- Norbert Wiener
-- next part --
An HTML attachment was scrubbed...
URL:
<http://lists.mcs.anl.gov/pipermail/petsc-dev/attachments/20120824/59464a9b/attachment-0001.html>
eir experiments
> lead.
> -- Norbert Wiener
--
Department of Mathematics and Center for Computation & Technology
Louisiana State University, Baton Rouge, LA 70803, USA
Tel. +1 (225) 578 1612, Fax +1 (225) 578 4276 http://www.math.lsu.edu/~bourdin
-- next part
tational Physics, Carnegie Mellon University, 2009
> chris.eldred at gmail.com
>
--
What most experimenters take for granted before they begin their
experiments is infinitely more interesting than any results to which their
experiments lead.
-- Norbert Wiener
-- next part --
An HTML attachment was scrubbed...
URL:
<http://lists.mcs.anl.gov/pipermail/petsc-dev/attachments/20120824/029c3e03/attachment.html>
Jose,
Thanks!
One issue. I saw there is special treatment for quad precision in
PetscBinaryRead:
#if defined(PETSC_USE_REAL___FLOAT128)
double*ppp;
#endif
...
#if defined(PETSC_USE_REAL___FLOAT128)
/* If using __float128 precision we still read in doubles from file */
if (t
The following code snippet does not appear to be working:
PetscInt, dimension(4) :: EC
EC(1) = 1
EC(2) = 2
EC(3) = 3
EC(4) = 4
write(*,*) 'cell',EC
call DMComplexSetCone(model_mesh, lcell , EC, ierr)
CHKERRQ(ierr)
call DMComplexGetCone(model_mesh, lcell , EC, ierr)
CHKERRQ(ierr)
write(*,*) 'cell'
16 matches
Mail list logo
