Re: [petsc-dev] Bad use of defined(MPI_XXX)

2019-05-24 Thread Jed Brown via petsc-dev
To be fair, Microsoft just doesn't have resources left over for MPI after all they've been putting into making sure nobody in China learns about Tiananmen Square. "Smith, Barry F. via petsc-dev" writes: > MS-MPI has in their include file > > #define MPI_VERSION 2 > #define MPI_SUBVERSION

Re: [petsc-dev] Bad use of defined(MPI_XXX)

2019-05-24 Thread Smith, Barry F. via petsc-dev
MS-MPI has in their include file #define MPI_VERSION 2 #define MPI_SUBVERSION 0 Their last release was Oct 2018 https://docs.microsoft.com/en-us/message-passing-interface/microsoft-mpi-release-notes They also don't provide a mpi.mod file though they do provide mpif.h and Fortran

Re: [petsc-dev] Bad use of defined(MPI_XXX)

2019-05-24 Thread Zhang, Junchao via petsc-dev
PetscSF has many PETSC_HAVE_MPI_REDUCE_LOCAL. It is disturbing. But consider the time gap between MPI-2.0 (1998) and MPI-2.2 (2009), it is better to keep it. On Fri, May 24, 2019 at 3:53 PM Jed Brown mailto:j...@jedbrown.org>> wrote: "Zhang, Junchao" mailto:jczh...@mcs.anl.gov>> writes: > How

Re: [petsc-dev] Bad use of defined(MPI_XXX)

2019-05-24 Thread Jed Brown via petsc-dev
"Zhang, Junchao" writes: > How about stuff in MPI-2.2 (approved in 2009), the last of MPI-2.x, e.g., > PETSC_HAVE_MPI_REDUCE_LOCAL? Currently we only require MPI-2.0, but I would not object to increasing to MPI-2.1 or 2.2 if such systems are sufficiently rare (almost nonexistent) in the wild.

Re: [petsc-dev] Bad use of defined(MPI_XXX)

2019-05-24 Thread Zhang, Junchao via petsc-dev
How about stuff in MPI-2.2 (approved in 2009), the last of MPI-2.x, e.g., PETSC_HAVE_MPI_REDUCE_LOCAL? On Fri, May 24, 2019 at 2:51 PM Jed Brown via petsc-dev mailto:petsc-dev@mcs.anl.gov>> wrote: Lisandro Dalcin via petsc-dev mailto:petsc-dev@mcs.anl.gov>> writes: > These two are definitely

Re: [petsc-dev] Bad use of defined(MPI_XXX)

2019-05-24 Thread Jed Brown via petsc-dev
Lisandro Dalcin via petsc-dev writes: > These two are definitely wrong, we need PETSC_HAVE_MPI_XXX instead. Thanks, we can delete both of these cpp guards. > include/petscsf.h:#if defined(MPI_REPLACE) MPI-2.0 > src/sys/objects/init.c:#if defined(PETSC_USE_64BIT_INDICES) || >

[petsc-dev] Bad use of defined(MPI_XXX)

2019-05-24 Thread Lisandro Dalcin via petsc-dev
These two are definitely wrong, we need PETSC_HAVE_MPI_XXX instead. include/petscsf.h:#if defined(MPI_REPLACE) src/sys/objects/init.c:#if defined(PETSC_USE_64BIT_INDICES) || !defined(MPI_2INT) -- Lisandro Dalcin Research Scientist Extreme Computing Research Center (ECRC) King