Re: [petsc-dev] Unused macros in petscconf.h

2019-06-28 Thread Jed Brown via petsc-dev
Matthew Knepley writes: > On Fri, Jun 28, 2019 at 2:04 PM Smith, Barry F. via petsc-dev < > petsc-dev@mcs.anl.gov> wrote: > >> >> You are right, these do not belong in petscconf.h >> > > The problematic thing here is hiding information from users of > PETSc. If you are a user that counts on

Re: [petsc-dev] Unused macros in petscconf.h

2019-06-28 Thread Smith, Barry F. via petsc-dev
Some of the material collected could go into another file that is stored in the same location available to users but not included by PETSc source. Other material like PETSC_HAVE_LIBPNETCDF doesn't seem to be worthing putting in include files. We already have the macros PETSC_HAVE_PNETCDF

Re: [petsc-dev] PETSc blame digest (next-tmp) 2019-06-28

2019-06-28 Thread Smith, Barry F. via petsc-dev
Pushed fix > On Jun 28, 2019, at 3:28 PM, PETSc checkBuilds > wrote: > > > > Dear PETSc developer, > > This email contains listings of contributions attributed to you by > `git blame` that caused compiler errors or warnings in PETSc automated > testing. Follow the links to see the full

Re: [petsc-dev] Unused macros in petscconf.h

2019-06-28 Thread Smith, Barry F. via petsc-dev
You are right, these do not belong in petscconf.h Barry > On Jun 28, 2019, at 12:37 PM, Jed Brown via petsc-dev > wrote: > > We have a lot of lines like this > > $ grep -c HAVE_LIB $PETSC_ARCH/include/petscconf.h > 96 > > but only four of these are ever checked in src/. Delete them?

[petsc-dev] Unused macros in petscconf.h

2019-06-28 Thread Jed Brown via petsc-dev
We have a lot of lines like this $ grep -c HAVE_LIB $PETSC_ARCH/include/petscconf.h 96 but only four of these are ever checked in src/. Delete them? IMO, unused stuff should not go into petscconf.h. We have to scroll up past these lines every time configure crashes. These are apparently all

Re: [petsc-dev] configure using stale packages

2019-06-28 Thread Jed Brown via petsc-dev
"Smith, Barry F." writes: >If we stash the --download-xxx=yyy yyy value and the state of the xxx.py > then we can know that the package may be need to be re-downloaded, > re-configured, rebuilt, reinstalled. Essentially get the dependencies of > package xxx on itself right. There is

Re: [petsc-dev] configure using stale packages

2019-06-28 Thread Smith, Barry F. via petsc-dev
If we stash the --download-xxx=yyy yyy value and the state of the xxx.py then we can know that the package may be need to be re-downloaded, re-configured, rebuilt, reinstalled. Essentially get the dependencies of package xxx on itself right. There is also the dependency of package xxx

Re: [petsc-dev] configure using stale packages

2019-06-28 Thread Balay, Satish via petsc-dev
On Fri, 28 Jun 2019, Jed Brown wrote: > "Balay, Satish" writes: > > > On Fri, 28 Jun 2019, Jed Brown via petsc-dev wrote: > > > >> If we configure with --download-pnetcdf (version 1.9.0), then update the > >> PETSc repository to use a new version (1.11.2), then re-run ./configure > >>

Re: [petsc-dev] configure using stale packages

2019-06-28 Thread Jed Brown via petsc-dev
"Balay, Satish" writes: > On Fri, 28 Jun 2019, Jed Brown via petsc-dev wrote: > >> If we configure with --download-pnetcdf (version 1.9.0), then update the >> PETSc repository to use a new version (1.11.2), then re-run ./configure >> --download-pnetcdf, we get a warning making us look like

Re: [petsc-dev] configure using stale packages

2019-06-28 Thread Balay, Satish via petsc-dev
On Fri, 28 Jun 2019, Jed Brown via petsc-dev wrote: > If we configure with --download-pnetcdf (version 1.9.0), then update the > PETSc repository to use a new version (1.11.2), then re-run ./configure > --download-pnetcdf, we get a warning making us look like dolts: > >

[petsc-dev] configure using stale packages

2019-06-28 Thread Jed Brown via petsc-dev
If we configure with --download-pnetcdf (version 1.9.0), then update the PETSc repository to use a new version (1.11.2), then re-run ./configure --download-pnetcdf, we get a warning making us look like dolts: ===