Re: [petsc-dev] C++ and hypre long long int vs PETSc int64_t for 64 bit integer builds

2022-04-13 Thread Barry Smith
Thanks, but this is not my package. It is AMReX, I'm sure they won't have a problem with different tests but they may have problems with "still need some casts depending on usage". Barry > On Apr 13, 2022, at 10:13 AM, Jed Brown wrote: > > C/C++ integer hierarchy was a mistake, with

Re: [petsc-dev] C++ and hypre long long int vs PETSc int64_t for 64 bit integer builds

2022-04-13 Thread Stefano Zampini
This is what we currently have in PETSc, we check for sizeof and cast Il giorno mer 13 apr 2022 alle ore 17:13 Jed Brown ha scritto: > C/C++ integer hierarchy was a mistake, with the language-specified types > overlapping and the size-specific (int64_t) being typedefs. So long is > "different"

Re: [petsc-dev] C++ and hypre long long int vs PETSc int64_t for 64 bit integer builds

2022-04-13 Thread Jed Brown
C/C++ integer hierarchy was a mistake, with the language-specified types overlapping and the size-specific (int64_t) being typedefs. So long is "different" from long long even if they're both 64-bit signed integers. I think they should test that sizeof(HYPRE_Int) == sizeof(PetscInt), but not

[petsc-dev] C++ and hypre long long int vs PETSc int64_t for 64 bit integer builds

2022-04-13 Thread Barry Smith
For 64 bit integer builds AMReX has this test in their code CMakeFiles/amrex.dir/F_Interfaces/Base/AMReX_multifab_mod.F90.o /lcrc/project/PhloughToolz/petsc/petsc-3.17.0_oneAPI_2021.4.0.3422/externalpackages/git.amrex/Src/Extern/PETSc/AMReX_PETSc.cpp(44): error: static assertion failed with