[petsc-dev] tests coverage

2022-08-12 Thread Blaise Bourdin
Hi, Is the source coverage analysis by the tests easily available? When submitting a MR, I want to know if adding a test is necessary. Regards, Blaise — Tier 1 Canada Research Chair in Mathematical and Computational Aspects of Solid Mechanics Professor, Department of Mathematics & Statistics

Re: [petsc-dev] tests coverage

2022-08-12 Thread Satish Balay via petsc-dev
There is some coverage info - there are a couple of gcov tests - but that doesn't show coverage from all tests. For ex: https://gitlab.com/petsc/petsc/-/merge_requests/5509 click on the last stage/job of the pipeline 'analyze-pipeline' i.e https://gitlab.com/petsc/petsc/-/jobs/2841119765 Here -

Re: [petsc-dev] tests coverage

2022-08-12 Thread Jed Brown
We should report coverage to GitLab, in which case it'll annotate the diff. For example, this MR shows a red mark on this line that isn't covered by the tests, versus green marks for the covered changes. https://gitlab.com/micromorph/ratel/-/merge_requests/199/diffs#9f067f1470c81c8dda08481fdd5c6

Re: [petsc-dev] tests coverage

2022-08-12 Thread Blaise Bourdin
thanks Satish, That doesn’t seem quite right, though. For instance, I see that https://petsc.gitlab.io/-/petsc/-/jobs/2841119765/artifacts/arch-ci-analyze-pipeline/index_gcov.html reports only 30 testable lines in plexexodusii.c, none of which are tested, while I know that there are mu

Re: [petsc-dev] tests coverage

2022-08-12 Thread Satish Balay via petsc-dev
I think there is some logic there that marks only the lines from the MR diff. Barry might remember this correctly. Satish On Fri, 12 Aug 2022, Blaise Bourdin wrote: > thanks Satish, > > That doesn’t seem quite right, though. For instance, I see that  > https://petsc.gitlab.io/-/petsc/-/jobs/28

Re: [petsc-dev] tests coverage

2022-08-12 Thread Barry Smith
The MR was almost perfect. Then we switched from launching pipelines directly to doing them through the MR, which changed the way some of the information was formatted. We should wire this up properly and then require MR not to introduce new lines of untested code. It has been on my to-do li