Re: [petsc-dev] Symbol names using clang in addition to gcc

2022-09-22 Thread Satish Balay via petsc-dev
MR with this fix at https://gitlab.com/petsc/petsc/-/merge_requests/5672 Satish On Thu, 22 Sep 2022, Satish Balay via petsc-dev wrote: > Perhaps the following change. > > Satish > --- > > diff --git a/src/sys/dll/dlimpl.c b/src/sys/dll/dlimpl.c > index fc488603167..63eba0d2fb3 100644 > ---

Re: [petsc-dev] Symbol names using clang in addition to gcc

2022-09-22 Thread Satish Balay via petsc-dev
Perhaps the following change. Satish --- diff --git a/src/sys/dll/dlimpl.c b/src/sys/dll/dlimpl.c index fc488603167..63eba0d2fb3 100644 --- a/src/sys/dll/dlimpl.c +++ b/src/sys/dll/dlimpl.c @@ -327,7 +327,7 @@ PetscErrorCode PetscDLAddr(void (*func)(void), char **name) PetscFunctionBegin;

Re: [petsc-dev] Symbol names using clang in addition to gcc

2022-09-22 Thread Satish Balay via petsc-dev
Actually the failure on Cray is with clang. So I'm not sure the best way to fix this is. Satish -- [balay@login2.crusher petsc]$ CC --version Cray clang version 14.0.0 (c98838affc7b58fed2a72f164d77c35e1bc8772f) Target: x86_64-unknown-linux-gnu Thread model: posix InstalledDir:

Re: [petsc-dev] Symbol names using clang in addition to gcc

2022-09-22 Thread Satish Balay via petsc-dev
I see this is change was done at https://gitlab.com/petsc/petsc/-/merge_requests/5268 Likely due to errors with cray compilers. So I guess we could add in __clang__ as you suggest. Can you create an MR with this change? And probably the same fix for src/sys/objects/pinit.c ? Satish On Thu,

[petsc-dev] Symbol names using clang in addition to gcc

2022-09-22 Thread Aagaard, Brad T via petsc-dev
Satish, I used to be able to get symbol names using clang (macOS) and this still works, but I need to edit the defines in dlimpl.c because __USE_GNU is not defined. Is there a reason why the current code is limited to __USE_GNU and doesn’t allow broader use when it works? Here is the change I