Re: [petsc-dev] So CFLAGS no longer works!!!! Major crisis

2023-04-26 Thread Barry Smith
Looks like something like ifeq ($(origin CFLAGS),environment) might work to bring back the old behavior. > On Apr 26, 2023, at 6:16 PM, Satish Balay wrote: > > Not sure how can add deprecation message here - so adding this message to > 'changes' doc > >

Re: [petsc-dev] So CFLAGS no longer works!!!! Major crisis

2023-04-26 Thread Satish Balay via petsc-dev
Not sure how can add deprecation message here - so adding this message to 'changes' doc https://gitlab.com/petsc/petsc/-/merge_requests/6382 Satish On Wed, 26 Apr 2023, Satish Balay via petsc-dev wrote: > On Wed, 26 Apr 2023, Barry Smith wrote: > > > > > > > Urg, so user makefiles that

Re: [petsc-dev] So CFLAGS no longer works!!!! Major crisis

2023-04-26 Thread Satish Balay via petsc-dev
On Wed, 26 Apr 2023, Barry Smith wrote: > > > Urg, so user makefiles that worked for 25+ years suddenly don't work and > that is ok? No deprecation message as Jed would have liked? I think I raised this issue when 'CFLAGS = ' stuff was removed from all makefiles. You can view this change

Re: [petsc-dev] So CFLAGS no longer works!!!! Major crisis

2023-04-26 Thread Barry Smith
Urg, so user makefiles that worked for 25+ years suddenly don't work and that is ok? No deprecation message as Jed would have liked? So it is from # Avoid picking CFLAGS etc from env - but support 'make CFLAGS=-Werror' etc.. self.addMakeMacro('CFLAGS','')

Re: [petsc-dev] So CFLAGS no longer works!!!! Major crisis

2023-04-26 Thread Satish Balay via petsc-dev
Also note: I think we previously handled this by always having this in each makefile [without a configure default] CFLAGS = But that format was removed.. Satish On Wed, 26 Apr 2023, Satish Balay via petsc-dev wrote: > Well we wanted to always have CFLAGS initialized by configure [to

Re: [petsc-dev] So CFLAGS no longer works!!!! Major crisis

2023-04-26 Thread Satish Balay via petsc-dev
Well we wanted to always have CFLAGS initialized by configure [to ignore stuff from env]. So now - if we are setting in makefile - it has to be set after this default is set - i.e after the line: include ${PETSC_DIR}/lib/petsc/conf/variables Or do: make CFLAGS=garbase ex1 There might be a

[petsc-dev] So CFLAGS no longer works!!!! Major crisis

2023-04-26 Thread Barry Smith
$ make ex1 mpicc -Wl,-bind_at_load -Wl,-multiply_defined,suppress -Wl,-multiply_defined -Wl,suppress -Wl,-commons,use_dylibs -Wl,-search_paths_first -Wl,-no_compact_unwind -Wall -Wwrite-strings -Wno-unknown-pragmas -Wno-lto-type-mismatch -Wno-stringop-overflow -fvisibility=hidden -g3 -O0