I've removed 'team' from default approval rules again..
Satish
On Wed, 30 Oct 2019, Zhang, Hong via petsc-dev wrote:
> After some discussion with Satish, I realized that currently the approval
> rules default to Integration, Team and Code Owner and all these groups are
> carried over as
After some discussion with Satish, I realized that currently the approval rules
default to Integration, Team and Code Owner and all these groups are carried
over as participants for MRs. It is reasonable to keep integrators and
codeowners in the list since they should definitely look at the MR.
On Mon, 21 Oct 2019, Zhang, Hong via petsc-dev wrote:
> How is the list of participants determined when a MR is created on gitlab? It
> seems to include everybody by default. Is there any way to shorten the list?
> Ideally only the participants involved in the particular MR should be picked.
>
> On Oct 21, 2019, at 10:53 AM, Fande Kong wrote:
>
> I have these troubles as well. I know nothing about gitlab.
>
> It would be great if we could have the same setting as we had in bitbucket
> before.
I don't think there is a simple mapping.
>
> Fande.
>
> On Mon, Oct 21, 2019 at
> On Oct 21, 2019, at 10:27 AM, Zhang, Hong via petsc-dev
> wrote:
>
> How is the list of participants determined when a MR is created on gitlab? It
> seems to include everybody by default. Is there any way to shorten the list?
> Ideally only the participants involved in the particular MR
All "developers" are listed as able to grant (optional) approvals --
approval from codeowners/integrators is still needed regardless of those
optional approvals. We should perhaps remove that because I don't know
a way to have some able to approve without the notification problem you
mention
How is the list of participants determined when a MR is created on gitlab? It
seems to include everybody by default. Is there any way to shorten the list?
Ideally only the participants involved in the particular MR should be picked.
Note that currently there is a huge gap between the