Re: [petsc-dev] AVX kernels, old gcc, still broken

"Smith, Barry F." writes: >> On Oct 26, 2019, at 9:09 AM, Jed Brown wrote: >> >> "Smith, Barry F." writes: >> >>> The proposed fix is #if defined(PETSC_USE_AVX512_KERNELS) && && && && && >>> in https://gitlab.com/petsc/petsc/merge_requests/2213/diffs >> >> Looks fine; approved. >> >>>

Re: [petsc-dev] AVX kernels, old gcc, still broken

> On Oct 26, 2019, at 9:09 AM, Jed Brown wrote: > > "Smith, Barry F." writes: > >> The proposed fix is #if defined(PETSC_USE_AVX512_KERNELS) && && && && && >> in https://gitlab.com/petsc/petsc/merge_requests/2213/diffs > > Looks fine; approved. > >> but note that

Re: [petsc-dev] AVX kernels, old gcc, still broken

"Smith, Barry F." writes: > The proposed fix is #if defined(PETSC_USE_AVX512_KERNELS) && && && && && > in https://gitlab.com/petsc/petsc/merge_requests/2213/diffs Looks fine; approved. > but note that PETSC_USE_AVX512_KERNELS does not even do a configure check to > make sure it is valid.

Re: [petsc-dev] AVX kernels, old gcc, still broken

The proposed fix is #if defined(PETSC_USE_AVX512_KERNELS) && && && && && in https://gitlab.com/petsc/petsc/merge_requests/2213/diffs but note that PETSC_USE_AVX512_KERNELS does not even do a configure check to make sure it is valid. The user has to guess that passing that flag will work.

Re: [petsc-dev] AVX kernels, old gcc, still broken

"Smith, Barry F. via petsc-dev" writes: >This needs to be fixed properly with a configure test(s) and not with huge > and inconsistent checks like this > > #if defined(PETSC_HAVE_IMMINTRIN_H) && defined(__AVX512F__) && > defined(PETSC_USE_REAL_DOUBLE) && !defined(PETSC_USE_COMPLEX) && >

Re: [petsc-dev] AVX kernels, old gcc, still broken

https://gitlab.com/petsc/petsc/issues/434 > On Oct 25, 2019, at 9:16 AM, Smith, Barry F. wrote: > > > This needs to be fixed properly with a configure test(s) and not with huge > and inconsistent checks like this > > #if defined(PETSC_HAVE_IMMINTRIN_H) && defined(__AVX512F__) && >

Re: [petsc-dev] AVX kernels, old gcc, still broken

This needs to be fixed properly with a configure test(s) and not with huge and inconsistent checks like this #if defined(PETSC_HAVE_IMMINTRIN_H) && defined(__AVX512F__) && defined(PETSC_USE_REAL_DOUBLE) && !defined(PETSC_USE_COMPLEX) && !defined(PETSC_USE_64BIT_INDICES) or this #elif

Re: [petsc-dev] AVX kernels, old gcc, still broken

On Fri, 25 Oct 2019 at 01:40, Balay, Satish wrote: > I'm curious why this issue comes up for you. The code was unrelated to > --with-avx512-kernels=0 option. > > Its relying on __AVX512F__and PETSC_HAVE_IMMINTRIN_H flags. And > assumes immintrin.h has a definition for _mm512_reduce_add_pd() > >

Re: [petsc-dev] AVX kernels, old gcc, still broken

I'm curious why this issue comes up for you. The code was unrelated to --with-avx512-kernels=0 option. Its relying on __AVX512F__and PETSC_HAVE_IMMINTRIN_H flags. And assumes immintrin.h has a definition for _mm512_reduce_add_pd() Is the flag __AVX512F__ always set on your machine by gcc? And

Re: [petsc-dev] AVX kernels, old gcc, still broken

Hi Lisandro, Can you please check if the following patch fixes the problem? I will create a MR. diff --git a/src/mat/impls/aij/seq/aijperm/aijperm.c b/src/mat/impls/aij/seq/aijperm/aijperm.c index 577dfc6713..568535117a 100644 --- a/src/mat/impls/aij/seq/aijperm/aijperm.c +++