Re: [petsc-dev] Pause-for-approval Pipelines?

2020-08-28 Thread Jed Brown
Satish Balay writes: > On Thu, 27 Aug 2020, Jed Brown wrote: > >> If you make an account, I can add you so you can see the settings >> >> https://readthedocs.org/projects/petsc/ >> >> Currently, it's Patrick, Vaclav, and me. > > Ok - account created now [via gitlab] so I'm sbalay at readthedocs

Re: [petsc-dev] Pause-for-approval Pipelines?

2020-08-28 Thread Satish Balay via petsc-dev
On Thu, 27 Aug 2020, Jed Brown wrote: > If you make an account, I can add you so you can see the settings > > https://readthedocs.org/projects/petsc/ > > Currently, it's Patrick, Vaclav, and me. Ok - account created now [via gitlab] so I'm sbalay at readthedocs.org Satish

Re: [petsc-dev] Pause-for-approval Pipelines?

2020-08-27 Thread Jed Brown
Satish Balay via petsc-dev writes: > On Thu, 27 Aug 2020, Satish Balay via petsc-dev wrote: > >> I don't understand how readthedocs is setup or how it works. And I think its >> the cause for most of the current issues. >> >> Its best to disable it completely for now - and see if most of the cur

Re: [petsc-dev] Pause-for-approval Pipelines?

2020-08-27 Thread Satish Balay via petsc-dev
[want to respond to this part] On Thu, 27 Aug 2020, Barry Smith wrote: > Generally I like to pass the Pipeline before making a PR. This is api/web pipeline - and continues to work as before. > So the test on creating a new MR is annoying. There is no change wrt MR creation [wrt the merge_req

Re: [petsc-dev] Pause-for-approval Pipelines?

2020-08-27 Thread Satish Balay via petsc-dev
On Thu, 27 Aug 2020, Satish Balay via petsc-dev wrote: > I don't understand how readthedocs is setup or how it works. And I think its > the cause for most of the current issues. > > Its best to disable it completely for now - and see if most of the current > issues go away or not Ok I see the

Re: [petsc-dev] Pause-for-approval Pipelines?

2020-08-27 Thread Satish Balay via petsc-dev
On Thu, 27 Aug 2020, Barry Smith wrote: > > > > On Aug 27, 2020, at 6:25 PM, Satish Balay wrote: > > > > On Thu, 27 Aug 2020, Satish Balay via petsc-dev wrote: > > > >> The above is hard for me to digest - so I think its best to frame this > >> differently. > >> > >> 1. ReadTheDocs is not

Re: [petsc-dev] Pause-for-approval Pipelines?

2020-08-27 Thread Barry Smith
> On Aug 27, 2020, at 6:25 PM, Satish Balay wrote: > > On Thu, 27 Aug 2020, Satish Balay via petsc-dev wrote: > >> The above is hard for me to digest - so I think its best to frame this >> differently. >> >> 1. ReadTheDocs is not setup in .gitlab-ci.yml >> >> 2. We have merge_request pipe

Re: [petsc-dev] Pause-for-approval Pipelines?

2020-08-27 Thread Barry Smith
Can't see where the test is that decides if a docs pipeline is needed and launched but presumably it is there somewhere in all the syntax. https://gitlab.com/gitlab-org/gitlab/-/blob/86bc0e2ed2fa32198a562e09bf36dab5821ece22/scripts/trigger-build

Re: [petsc-dev] Pause-for-approval Pipelines?

2020-08-27 Thread Satish Balay via petsc-dev
On Thu, 27 Aug 2020, Satish Balay via petsc-dev wrote: > The above is hard for me to digest - so I think its best to frame this > differently. > > 1. ReadTheDocs is not setup in .gitlab-ci.yml > > 2. We have merge_request pipelines - and web pipelines [api pipeline is > similar to web] > > 3

Re: [petsc-dev] Pause-for-approval Pipelines?

2020-08-27 Thread Satish Balay via petsc-dev
On Thu, 27 Aug 2020, Barry Smith wrote: > > > > On Aug 27, 2020, at 4:55 PM, Jed Brown wrote: > > > > Barry Smith writes: > > > >>> - readdocs pipeline > >>> - merge-pipeline - auto starts - does the pre stage and pauses. > >> > >> how are they related? > > > > Not at all. The ReadTheDo

Re: [petsc-dev] Pause-for-approval Pipelines?

2020-08-27 Thread Scott Kruger
What's wrong with using the API to release the paused job instead of using it to start a fresh pipeline? Generally I like to pass the Pipeline before making a PR. So the test on creating a new MR is annoying. Yes after the initial MR I might be able to release the paused job in lieu of st

Re: [petsc-dev] Pause-for-approval Pipelines?

2020-08-27 Thread Barry Smith
> On Aug 27, 2020, at 4:55 PM, Jed Brown wrote: > > Barry Smith writes: > >>> - readdocs pipeline >>> - merge-pipeline - auto starts - does the pre stage and pauses. >> >> how are they related? > > Not at all. The ReadTheDocs pipeline is managed by readthedocs.org. > >> I understood Je

Re: [petsc-dev] Pause-for-approval Pipelines?

2020-08-27 Thread Satish Balay via petsc-dev
On Thu, 27 Aug 2020, Jed Brown wrote: > Barry Smith writes: > > >> - readdocs pipeline > >> - merge-pipeline - auto starts - does the pre stage and pauses. > > > > how are they related? > > Not at all. The ReadTheDocs pipeline is managed by readthedocs.org. > > > I understood Jed wanted the

Re: [petsc-dev] Pause-for-approval Pipelines?

2020-08-27 Thread Satish Balay via petsc-dev
On Thu, 27 Aug 2020, Barry Smith wrote: > The second pipeline I don't understand. Aside from letting people who don't > use the GitLab API to not have to hunt for the Pipelines window and cut and > past their branch name in and the merge to master business does it serve any > other purpose? w

Re: [petsc-dev] Pause-for-approval Pipelines?

2020-08-27 Thread Jed Brown
Barry Smith writes: >> - readdocs pipeline >> - merge-pipeline - auto starts - does the pre stage and pauses. > > how are they related? Not at all. The ReadTheDocs pipeline is managed by readthedocs.org. > I understood Jed wanted the readdocs pipeline done automatically so it was > easy to

Re: [petsc-dev] Pause-for-approval Pipelines?

2020-08-27 Thread Barry Smith
> On Aug 27, 2020, at 11:45 AM, Satish Balay via petsc-dev > wrote: > > On Thu, 27 Aug 2020, Jacob Faibussowitsch wrote: > >> Why does one pipeline request spawn two separate pipelines now? Specifically >> one is a normal pipeline whereas the other includes some sort of manual >> approval

Re: [petsc-dev] Pause-for-approval Pipelines?

2020-08-27 Thread Satish Balay via petsc-dev
The CI process does a merge of the branch with master - and uses this commit for the test pipeline. i.e the branch is not modified. Obviously if the merge fails - the test pipeline won''t get run.. [when there are merge conflicts - the MR page indicates this anyway] Satish On Thu, 27 Aug 2020,

Re: [petsc-dev] Pause-for-approval Pipelines?

2020-08-27 Thread Scott Kruger
Does branch+master mean an automatic rebase? Scott On 8/27/20 10:59 AM, Satish Balay via petsc-dev wrote: BTW: here are some reasons for using the MR pipeline instead of the web interface pipeline. - it tests branch+master (more useful?) - instead of branch [web pipeline]. - you can skip t

Re: [petsc-dev] Pause-for-approval Pipelines?

2020-08-27 Thread Satish Balay via petsc-dev
An improvement would be: disable the auto-start of the MR pipelines [and only enable 'Run pipeline' option on the 'pipeline tab']. But we don't know how to do this.. The current Pause-for-approval (in pre stage) is a away stop this auto-started MR pipeline - and 'continue' only if we need this

Re: [petsc-dev] Pause-for-approval Pipelines?

2020-08-27 Thread Stefano Zampini
+1 for the new infrastructure > On Aug 27, 2020, at 6:59 PM, Satish Balay via petsc-dev > wrote: > > BTW: here are some reasons for using the MR pipeline instead of the web > interface pipeline. > > - it tests branch+master (more useful?) - instead of branch [web pipeline]. > - you can skip

Re: [petsc-dev] Pause-for-approval Pipelines?

2020-08-27 Thread Satish Balay via petsc-dev
Additional note: One way to completely avoid MR pipelines is to not create an MR for a work-in-progress branch Satish On Thu, 27 Aug 2020, Satish Balay via petsc-dev wrote: > BTW: here are some reasons for using the MR pipeline instead of the web > interface pipeline. > > - it tests branch+m

Re: [petsc-dev] Pause-for-approval Pipelines?

2020-08-27 Thread Satish Balay via petsc-dev
BTW: here are some reasons for using the MR pipeline instead of the web interface pipeline. - it tests branch+master (more useful?) - instead of branch [web pipeline]. - you can skip the forced re-bases that were required when CI changed [i.e even if your branch is off old master - the latest C

Re: [petsc-dev] Pause-for-approval Pipelines?

2020-08-27 Thread Satish Balay via petsc-dev
On Thu, 27 Aug 2020, Jacob Faibussowitsch wrote: > Why does one pipeline request spawn two separate pipelines now? Specifically > one is a normal pipeline whereas the other includes some sort of manual > approval button which “runs” indefinitely if you don’t either cancel it or > approve it. T

[petsc-dev] Pause-for-approval Pipelines?

2020-08-27 Thread Jacob Faibussowitsch
Hello All, Why does one pipeline request spawn two separate pipelines now? Specifically one is a normal pipeline whereas the other includes some sort of manual approval button which “runs” indefinitely if you don’t either cancel it or approve it. I think this was somewhat discussed in a previou