Barry Smith writes:
>Everybody gets on Jed’s bad side gitwise once in a while, don’t let that
> inhibit you getting work done.
Wow, I'm not old enough to get that reputation just yet. ;-)
Time to set up an automatic ABI checker to be cranky on my behalf.
pgpZ681LSxnxF.pgp
Description: PGP
On Sep 11, 2014, at 11:36 AM, Jose E. Roman wrote:
>
> El 11/09/2014, a las 00:32, Barry Smith escribió:
>
>>
>> Jose,
>>
>> Start by making PetscSplitReduction an opaque pointer to the actual struct.
>>
>> For example
>>
>> typedef struct _n_PetscSplitReduction *PetscSplitReduction;
El 11/09/2014, a las 00:32, Barry Smith escribió:
>
> Jose,
>
> Start by making PetscSplitReduction an opaque pointer to the actual struct.
>
> For example
>
> typedef struct _n_PetscSplitReduction *PetscSplitReduction;
>
> goes in the public include include/petscsys.h
>
> typedef
Jose,
Start by making PetscSplitReduction an opaque pointer to the actual struct.
For example
typedef struct _n_PetscSplitReduction *PetscSplitReduction;
goes in the public include include/petscsys.h
typedef struct {
- MPI_Commcomm;
- MPI_Request request;
- PetscBool asyn
El 09/07/2014, a las 23:39, Jed Brown escribió:
> Satish Balay writes:
>
>> merged to maint now.
>
> Satish, we can't have this non-namespaced stuff in 'maint' (it really
> can break user code). The struct definition should really be private
> (so if Jose needs to access fields, we need to wr
On Wed, 9 Jul 2014, Jed Brown wrote:
> Satish Balay writes:
> > Should I revert this merge or do something else?
> >
> > git revert -m 1 52cbd52866ccab13bc62001b3276d0b542ea4117
>
> Let's revert it now to avoid disrupting someone tracking 'maint'. Then
> we can fix the branch and put in the nec
Satish Balay writes:
> Should I revert this merge or do something else?
>
> git revert -m 1 52cbd52866ccab13bc62001b3276d0b542ea4117
Let's revert it now to avoid disrupting someone tracking 'maint'. Then
we can fix the branch and put in the necessary interface.
pgpsOHCiRyGEe.pgp
Description: P
On Wed, 9 Jul 2014, Jed Brown wrote:
> Satish Balay writes:
>
> > merged to maint now.
>
> Satish, we can't have this non-namespaced stuff in 'maint' (it really
> can break user code).
Sorry - should have checked the name space stuff.
> The struct definition should really be private
> (so if
Satish Balay writes:
> merged to maint now.
Satish, we can't have this non-namespaced stuff in 'maint' (it really
can break user code). The struct definition should really be private
(so if Jose needs to access fields, we need to write interface
functions).
I'm sorry about my radio silence on
merged to maint now.
thanks,
Satish
On Tue, 8 Jul 2014, Jose E. Roman wrote:
>
> El 10/06/2014, a las 10:01, Jose E. Roman escribió:
>
> >
> > El 08/06/2014, a las 13:13, Jose E. Roman escribió:
> >
> >>
> >> El 08/06/2014, a las 12:57, Jed Brown escribió:
> >>
> >>> "Jose E. Roman" write
El 10/06/2014, a las 10:01, Jose E. Roman escribió:
>
> El 08/06/2014, a las 13:13, Jose E. Roman escribió:
>
>>
>> El 08/06/2014, a las 12:57, Jed Brown escribió:
>>
>>> "Jose E. Roman" writes:
>>>
Would it be too much asking that PetscSplitReduction be available in a
public head
El 08/06/2014, a las 13:13, Jose E. Roman escribió:
>
> El 08/06/2014, a las 12:57, Jed Brown escribió:
>
>> "Jose E. Roman" writes:
>>
>>> Would it be too much asking that PetscSplitReduction be available in a
>>> public header? (together with the functions PetscSplitReductionGet,
>>> PetscS
El 08/06/2014, a las 12:57, Jed Brown escribió:
> "Jose E. Roman" writes:
>
>> Would it be too much asking that PetscSplitReduction be available in a
>> public header? (together with the functions PetscSplitReductionGet,
>> PetscSplitReductionEnd, PetscSplitReductionExtend).
>
> Sounds reasona
"Jose E. Roman" writes:
> Would it be too much asking that PetscSplitReduction be available in a
> public header? (together with the functions PetscSplitReductionGet,
> PetscSplitReductionEnd, PetscSplitReductionExtend).
Sounds reasonable to me. Do you want to prepare a patch? Otherwise I
can
Would it be too much asking that PetscSplitReduction be available in a public
header? (together with the functions PetscSplitReductionGet,
PetscSplitReductionEnd, PetscSplitReductionExtend).
I know this request comes too close to the release date.
Jose
15 matches
Mail list logo
