Re: [petsc-dev] Problem with unnamed side sets in DMPlexCreateExodus

2022-07-10 Thread David Andrs
Hi Matt! I tested your branch and it works as expected, i.e. no empty label is created on my ExodusII mesh file. I also left a comment on your MR on gitlab. Unfortunately I was not able to get to this this week, so thanks a lot for working on this - much appreciated. David > On Jul 9, 2022,

Re: [petsc-dev] Problem with unnamed side sets in DMPlexCreateExodus

2022-07-09 Thread Matthew Knepley
Hi David, Can you take a look at this and tell me whether it will work for you, or we should change it? https://gitlab.com/petsc/petsc/-/merge_requests/5415 Thanks, Matt On Sun, Jun 26, 2022 at 4:08 PM David Andrs wrote: > Hi Matt! > > On Jun 26, 2022, at 10:39, Matthew Knepley

Re: [petsc-dev] Problem with unnamed side sets in DMPlexCreateExodus

2022-07-01 Thread Jed Brown
David Andrs writes: > Hi Matt! > > On Jun 26, 2022, at 10:39, Matthew Knepley wrote: >> >> On Sun, Jun 26, 2022 at 8:31 AM David Andrs > > wrote: >> Hi Jed! >> >> I have been thinking about this and I think more correct would be not to >> create the label with an

Re: [petsc-dev] Problem with unnamed side sets in DMPlexCreateExodus

2022-06-26 Thread David Andrs
Hi Matt! On Jun 26, 2022, at 10:39, Matthew Knepley wrote: > > On Sun, Jun 26, 2022 at 8:31 AM David Andrs > wrote: > Hi Jed! > > I have been thinking about this and I think more correct would be not to > create the label with an empty name. It is not all or nothing

Re: [petsc-dev] Problem with unnamed side sets in DMPlexCreateExodus

2022-06-26 Thread Matthew Knepley
On Sun, Jun 26, 2022 at 8:31 AM David Andrs wrote: > Hi Jed! > > I have been thinking about this and I think more correct would be not to > create the label with an empty name. It is not all or nothing kind of a > deal. Some side sets may have a name, some may not. > > What I sent is probably

Re: [petsc-dev] Problem with unnamed side sets in DMPlexCreateExodus

2022-06-26 Thread David Andrs
Hi Jed! I have been thinking about this and I think more correct would be not to create the label with an empty name. It is not all or nothing kind of a deal. Some side sets may have a name, some may not. What I sent is probably more convenient, since after loading the mesh there is either a

Re: [petsc-dev] Problem with unnamed side sets in DMPlexCreateExodus

2022-06-25 Thread Jed Brown
Do you think this is more correct than just using "Face Sets", which gives you a numbered index? There is curently some inconsistency between file formats in whether various sets show up as stand-alone labels or values under Face Sets. And there's this lingering issue to have a way to name

[petsc-dev] Problem with unnamed side sets in DMPlexCreateExodus

2022-06-23 Thread David Andrs
Hello!The current behavior in DMPlexCreateExodus is assuming that side sets are always named. However, that is not always true. If there are unnamed side sets in an ExodusII file, the created DM will contain a label with an empty name (“”) with as many stratas as there are side sets. See the