Re: [petsc-dev] TSSetConvergedReason(ts,TS_CONVERGED_USER);

2021-02-18 Thread Mark Adams
OK, makes sense. I didn't know monitors were called before the step. Thanks, On Thu, Feb 18, 2021 at 7:25 AM Matthew Knepley wrote: > Stefano is right. Changes in convergence should probably go in TSPostStep. > > Thanks, > > Matt > > On Thu, Feb 18, 2021 at 7:22 AM Stefano Zampini > wrot

Re: [petsc-dev] TSSetConvergedReason(ts,TS_CONVERGED_USER);

2021-02-18 Thread Matthew Knepley
Stefano is right. Changes in convergence should probably go in TSPostStep. Thanks, Matt On Thu, Feb 18, 2021 at 7:22 AM Stefano Zampini wrote: > Mark > > monitors are not supposed to change the TS. You can think at monitors > being 'const' methods of the TS. Also, TSMonitor is called at

Re: [petsc-dev] TSSetConvergedReason(ts,TS_CONVERGED_USER);

2021-02-18 Thread Stefano Zampini
Mark monitors are not supposed to change the TS. You can think at monitors being 'const' methods of the TS. Also, TSMonitor is called at the beginning of each step , see here https://gitlab.com/petsc/petsc/-/blob/master/src/ts/interface/ts.c#L4169 Il giorno gio 18 feb 2021 alle ore 15:16 Mark Ad

[petsc-dev] TSSetConvergedReason(ts,TS_CONVERGED_USER);

2021-02-18 Thread Mark Adams
TSSetConvergedReason(ts,TS_CONVERGED_USER); does not seem to stop the iteration in a user monitor function. I have verified that it works from a post step method. Is this intentional? Mark